Minor follow ups to measure filter API changes #3779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
begelundmuller
approved these changes
Jan 4, 2024
Comment on lines
+508
to
+510
| if strings.TrimSpace(havingClause) != "" { | ||
| havingClause = "HAVING " + havingClause | ||
| } |
There was a problem hiding this comment.
It already checks that q.Having != nil – how can the it evaluate to an empty having clause if it's not nil?
There was a problem hiding this comment.
This is to gracefully handle cases with empty AND/OR or IN filters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While adding UI support for measure filters and the new filter format some changes were needed to not crash the API.