Adding support for sections in searchable filters #3778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericpgreen2
approved these changes
Jan 5, 2024
| @@ -127,6 +127,8 @@ | |||
| $: bgColor = dark | |||
| ? `${hovered ? "bg-gray-600" : ""}` | |||
| : `${hovered ? "bg-gray-200" : ""}`; | |||
|
|
|||
| $: console.log(icon, selected); | |||
There was a problem hiding this comment.
In the future, it'd be better to use Storybook rather than a /dev route, so these showcases aren't included in the production build.
|
I havent changed the color scheme. I believe that is to indicate that once selected, there should atleast be a single value. Either way it is a design concern and out of scope of this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation of adding measure filters we need measures and dimensions sections in the add filter drop down.
This PR only adds this grouping feature to our searchable filter component. Visit http://localhost:3000/dev/grouped-searchable-filter to check how it will look.