more strictNullChecks #3729
Merged
more strictNullChecks #3729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcolloran
commented
Dec 20, 2023
bcolloran
commented
Dec 20, 2023
| @@ -119,7 +119,7 @@ export function createSchemaForTable( | |||
| ) as ReturnType<typeof createConnectorServiceOLAPGetTable>; | |||
| } | |||
|
|
|||
| export function resourceIsLoading(resource: V1Resource) { | |||
| export function resourceIsLoading(resource?: V1Resource) { | |||
There was a problem hiding this comment.
already checks for undefined input right below, the function just wasn't typed correctly
|
@ericpgreen2 , picked off strictNullChecks in |
ericpgreen2
reviewed
Dec 21, 2023
ericpgreen2
reviewed
Dec 21, 2023
web-common/src/features/sources/workspace/SourceWorkspaceHeader.svelte
Outdated
Show resolved
Hide resolved
ericpgreen2
reviewed
Dec 21, 2023
| overlay.set({ title: `Importing ${tableName}.yaml` }); | ||
| await saveAndRefresh(tableName, $sourceStore.clientYAML); | ||
| checkSourceImported(queryClient, sourceName, filePath); | ||
| overlay.set(null); | ||
| }; | ||
|
|
||
| const onRefreshClick = async (tableName: string) => { | ||
| // no-op if connector is undefined | ||
| if (connector === undefined) return; |
There was a problem hiding this comment.
Similar to above. If connector is undefined, can we instead disable the Button so this code path is never hit?
There was a problem hiding this comment.
we can disable the button, but we can't take out this check because of the way the component is set up. In practice, I think this code path will never actually be hit anyway. This whole thing is ugly anyway (see eg the try/catch with a no-op directly below) and could use a refactor, but I'm gonna make the call that that's out of scope for this PR
ericpgreen2
reviewed
Dec 21, 2023
ericpgreen2
reviewed
Dec 21, 2023
ericpgreen2
reviewed
Dec 21, 2023
ericpgreen2
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #3373