Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move incomplete filters out of dashboard store and into a dedicated piece of state #3728

Merged
merged 5 commits into from
Dec 20, 2023

Conversation

briangregoryholmes
Copy link
Contributor

This PR moves temporary/potential/incomplete filters (those that do not have dimension values) outside of the dashboard store.

This addresses a change in the runtime that happened in #3624 that requires the in field of a filter be a nonempty array.

@briangregoryholmes briangregoryholmes self-assigned this Dec 19, 2023
@briangregoryholmes briangregoryholmes changed the title moves incomplete filters out of dashboardStore and into a dedicated piece of state move incomplete filters out of dashboard store and into a dedicated piece of state Dec 19, 2023
@briangregoryholmes briangregoryholmes marked this pull request as ready for review December 19, 2023 20:49
@ericpgreen2
Copy link
Contributor

Code looks good 👍

Approving, but one UXQA nit captured in this Jam to fix before merging:

  • I add one filter.
  • I start to add a subsequent filter and select a new dimension to filter on.
  • The dimension values from the prior filter flash before rendering the dimension values of the new dimension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants