Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding CONTINUOUS to comparison backwards compatibility code in url state loader #3719

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Adding CONTINUOUS to comparison backwards compatibility code in url state loader #3719

merged 1 commit into from
Dec 19, 2023

Conversation

AdityaHegde
Copy link
Collaborator

closes #3718

@AdityaHegde AdityaHegde added the blocker A release blocker issue that should be resolved before a new release label Dec 19, 2023
@ericpgreen2
Copy link
Contributor

ericpgreen2 commented Dec 19, 2023 •
edited
Loading

I see offsetIso can also be blank for TimeComparisonOption.CUSTOM...

image

... but I don't see a case for CUSTOM in fromProto.ts. Should there be one?

@AdityaHegde
Copy link
Collaborator Author

AdityaHegde commented Dec 19, 2023 •
edited
Loading

CUSTOM didnt change. Also we do not use offsetIso for CUSTOM and CONTINUOUS so that is fine.

@AdityaHegde AdityaHegde merged commit 75757c1 into main Dec 19, 2023
2 checks passed
@AdityaHegde AdityaHegde deleted the comparison-continuous-backwards-compatibility branch December 19, 2023 08:18
esevastyanov pushed a commit that referenced this pull request Dec 19, 2023
@AdityaHegde @esevastyanov
Adding CONTINUOUS to backwards compatibility code (#3719)
65556bb 
(cherry picked from commit 75757c1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericpgreen2 ericpgreen2 ericpgreen2 approved these changes

Assignees
No one assigned
Labels
blocker A release blocker issue that should be resolved before a new release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot read properties of undefined (reading 'offsetIso')
2 participants
@AdityaHegde @ericpgreen2