Only apply overscroll-behavior: none to Rill Developer
#3639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This works for me as expected on Chrome. Is it important enough that we should fire an event |
briangregoryholmes
approved these changes
Dec 7, 2023
Oh, fair callout. Currently, when a user attempts to navigates away from an unsaved source, we do have this dialog: It might be a little rabbit hole to reconcile two competing |
esevastyanov
pushed a commit
that referenced
this pull request
Dec 8, 2023
(cherry picked from commit 856d1d6)
mindspank
pushed a commit
that referenced
this pull request
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
overscroll-behavior: noneis CSS that prevents trackpad gesture navigation (given it's enabled at your OS level). Previously, this CSS lived in ourapp.cssfile, which applies to both Rill Cloud and Rill Developer. This PR move the CSS so that it only applies to Rill Developer.Code editors, or at least vscode.dev, tend to restrict this sort of trackpad navigation so that horizontally scrolling your code file does not accidentally trigger navigation.
Closes #3574