Configure Orval's generated error type #3614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcolloran
approved these changes
Dec 4, 2023
|
Thanks @ericpgreen2! so nice to see that I approved this fwiw, but I see you tagged @AdityaHegde as the desired reviewer so np if you want to wait for him to verify. |
|
Would it be simpler to just update fetchWrapper? |
I do think that'd be nicer, just it's a much larger scope change. I'd prefer to push that refactor down-the-line. |
esevastyanov
pushed a commit
that referenced
this pull request
Dec 8, 2023
* Move error type * Configure Orval's error type * Re-generate runtime client * Remove type cast * Remove file paths from `svelte-check` ignore (cherry picked from commit 0fbf031)
mindspank
pushed a commit
that referenced
this pull request
Dec 18, 2023
* Move error type * Configure Orval's error type * Re-generate runtime client * Remove type cast * Remove file paths from `svelte-check` ignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our custom http client, the
fetchWrapperfunction constructs a specifically-typed error. This PR configures Orval to generate our runtime client with this error type.Refer to line 31 in Orval's documentation for details on overriding the generated error type.
CC @bcolloran for visibility.