Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfixes in Scheduled Reports table #3470

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Bugfixes in Scheduled Reports table #3470

merged 2 commits into from
Nov 14, 2023

Conversation

ericpgreen2
Copy link
Contributor

This PR fixes two bugs in the scheduled reports table:

  • Project Viewers would see a 403 error because they're not allowed to call ListProjectMembers
  • The table header's search box threw an error when reportTime was undefined

@ericpgreen2 ericpgreen2 self-assigned this Nov 13, 2023
@ericpgreen2 ericpgreen2 added the blocker A release blocker issue that should be resolved before a new release label Nov 13, 2023
@ericpgreen2 ericpgreen2 mentioned this pull request Nov 13, 2023
Closed
16 tasks
@nishantmonu51 nishantmonu51 merged commit 1edef54 into main Nov 14, 2023
2 checks passed
@nishantmonu51 nishantmonu51 deleted the fix-bugs-in-reports-table branch November 14, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nishantmonu51 nishantmonu51 nishantmonu51 approved these changes

@djbarnwal djbarnwal Awaiting requested review from djbarnwal

Assignees

@ericpgreen2 ericpgreen2

Labels
blocker A release blocker issue that should be resolved before a new release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericpgreen2 @nishantmonu51