Add editable display name field to Metrics Config UI #1531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamilton
reviewed
Dec 22, 2022
There was a problem hiding this comment.
design looks ok, as per slack conversation.
@djbarnwal mind taking a look at the code?
djbarnwal
added a commit
that referenced
this pull request
Aug 3, 2023
* Move rename's `goto` into component logic * Create component to edit display name * Bump gap up 1em * Change header to rename file name not display name * Address feedback * Move background to tailwind class Co-authored-by: Dhiraj Kumar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1466