Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increases visual weight of filter icons in filter pill menu #1512

Merged
merged 1 commit into from
Dec 22, 2022
Merged

Conversation

bcolloran
Copy link
Contributor

fixes #1261 by darkening the icons in the filter pill

Note: this is a bit of a hack -- it hard codes the color because currentColor was not actually being set correctly by the upstream styles. There are a lot of layers of cascading in play here, so I thought this was an expedient solution to get us the look we want until we overhaul our approach to styling

this branch:
image

main (note lighter gray icons in filter pill menus_:
image

@hamilton hamilton self-requested a review December 22, 2022 01:06
Copy link
Contributor

@hamilton hamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@hamilton hamilton merged commit 19a7f11 into main Dec 22, 2022
@hamilton hamilton deleted the fix-1261 branch December 22, 2022 01:06
djbarnwal pushed a commit that referenced this pull request Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The visual weight of include/exclude icons are not heavy enough in the filter pills
2 participants