Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP query queue speedup #1501

Merged
merged 7 commits into from
Dec 27, 2022
Merged

HTTP query queue speedup #1501

merged 7 commits into from
Dec 27, 2022

Conversation

AdityaHegde
Copy link
Collaborator

No description provided.

@AdityaHegde AdityaHegde mentioned this pull request Dec 21, 2022
Closed
1 task
@AdityaHegde AdityaHegde changed the title Queue speedup HTTP query queue speedup Dec 21, 2022
@nishantmonu51
Copy link
Collaborator

  1. Should we also increase the default queue size to 20 ?
  2. would it also be possible to adapt the default to 200 if the app is hosted over https or on a remote server?

@AdityaHegde AdityaHegde marked this pull request as ready for review December 21, 2022 16:01
@AdityaHegde
Copy link
Collaborator Author

Updated queue size to 20. Also if it is https with a non localhost hostname then it is set to 200.

@hamilton
Copy link
Contributor

@magorlick would you mind taking a look at how this feels? This PR will hopefully make modeling feel a bit smoother / faster.

nishantmonu51
nishantmonu51 reviewed Dec 21, 2022
View reviewed changes
web-local/src/lib/http-request-queue/HttpRequestQueue.ts
try {
if (
window.location.protocol === "https:" &&
window.location.host !== "localhost"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be https OR localhost instead of AND ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@hamilton
Copy link
Contributor

@AdityaHegde Here's what I'm seeing in this branch:

  • it appears the cardinality + null plots get batch updated in one pass; that feels a little funky to me. Ideally we get that information ASAP and then get the ordering right.
  • it also appears that the cardinality + null plots are enqueued after the numeric histograms. They should probably be queried first
  • I'm not getting any kind of error feedback in the preview table when I type, no errors of any kind
Kapture.2022-12-21.at.14.57.10.mp4

@AdityaHegde
Copy link
Collaborator Author

@hamilton Fixed them. Please check now.

nishantmonu51
nishantmonu51 approved these changes Dec 27, 2022
View reviewed changes
Copy link
Collaborator

@nishantmonu51 nishantmonu51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nishantmonu51 nishantmonu51 merged commit b3b87fd into main Dec 27, 2022
@nishantmonu51 nishantmonu51 deleted the queue-speedup branch December 27, 2022 07:29
djbarnwal pushed a commit that referenced this pull request Aug 3, 2023
@AdityaHegde
HTTP query queue speedup (#1501)
4f34ad1 
* Fixing 500 errors

* Improving for quick requests

* Disabling tests and increasing queue size

* Fixing timestamp profile and histogram priotiy

* Allow navigation while porifiling

* QueueSize = 200 for https or not localhost
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nishantmonu51 nishantmonu51 nishantmonu51 approved these changes

@magorlick magorlick Awaiting requested review from magorlick

@hamilton hamilton Awaiting requested review from hamilton

Assignees

@AdityaHegde AdityaHegde

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AdityaHegde @nishantmonu51 @hamilton