Docker image building #1436
Merged
Docker image building #1436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
himadrisingh
commented
Dec 13, 2022
begelundmuller
requested changes
Dec 14, 2022
There was a problem hiding this comment.
- I think we can get rid of
entrypoint.shfile. Doesn't seem like something we use/do anymore. - Let's copy the
rillbinary to/rill, not/app/rill(or maybe to abinfolder?) - For the entrypoints, how about this? (Always forget the Docker mechanics for these, let me know if it looks bad):
ENTRYPOINT /rill
CMD /rill start
- Should we let the default workdir be
/project? So people should mount their artifacts there if they have an existing project. (Or do you have a more idiomatic suggestion, maybe/data?) (People can always override by passing--project /path/to/codeanyway)
himadrisingh
commented
Dec 15, 2022
kaspersjo
requested changes
Dec 15, 2022
himadrisingh
commented
Dec 15, 2022
ca-certs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.