Goreleaser setup #1279

rakeshsharma14317 · 2022-11-22T18:35:25Z

Adding steps release using goreleaser with homebrew setup

…oper into goreleaser-prototype

begelundmuller · 2022-12-05T10:31:24Z

.goreleaser.yaml

+  draft: true
+
+builds:
+  - id: darwin_amd4


Should be 64

begelundmuller · 2022-12-05T10:31:55Z

.github/workflows/cli-release.yml

+  schedule:
+    - cron: "0 0 * * *"


What's the point of having this now? Shouldn't it be for nightlies only (which aren't set up yet)

@himadrisingh Do we need this?

begelundmuller · 2022-12-05T10:34:05Z

.goreleaser.yaml

+    goarch:
+      - arm64
+    env:
+      - PKG_CONFIG_SYSROOT_DIR=/sysroot/macos/amd64
+      - PKG_CONFIG_PATH=/sysroot/macos/amd64/usr/local/lib/pkgconfig


@rakeshsharma14317, can you do some research and share your findings on possible implications of using a amd64 sysroot for an arm64 build target? Probably it's fine, just want to be sure – I don't know much about this

begelundmuller · 2022-12-05T10:38:11Z

.goreleaser.yaml

+archives:
+  - replacements:
+      darwin: Darwin
+      linux: Linux
+    files:
+      - README.md
+      - LICENSE*
+    name_template: "{{ .ProjectName }}_{{ .Os }}_{{ .Arch }}"


This is producing binary names with uppercase OS, see the screenshot. They should be all lowercase, e.g. rill_darwin_arm64.tar.gz

Also: Is there a way to output .zip files instead of .tar.gz? It's just more common/easy for people

@begelundmuller sure making it lowercase,
But on you second comment, what i found is mostly for mac and linux everyone prefers .tar.gz Only for window good to have .zip

@rakeshsharma14317 can you find out how to do zip and then will discuss options with product. But I think they'll prefer .zip, it's now very common on unix systems. E.g. duckdb only publishes .zip archives

begelundmuller · 2022-12-05T10:41:33Z

.goreleaser.yaml

+changelog:
+  sort: asc
+  filters:
+    exclude:
+      - "^docs:"
+      - "^test:"


Do these excludes match commit messages? We don't use prefixes for commit messages like this, so they'll have no effect. Is there a way to match paths instead?

Yeah as per their documentation we have

for e.g:

-# Paths to filter the commits for.
-# Only works when use: git, otherwise ignored.
-# Only on GoReleaser Pro.
-#
-# Default: monorepo.dir value, or empty if no monorepo.
-# Since: v1.12.0-pro
paths:

foo/

bar/

But looks like its for GoReleaser Pro.

For now removing filters as its of no use

begelundmuller · 2022-12-05T10:42:04Z

.github/workflows/cli-release.yml

+#    branches: [ "goreleaser-prototype" ]
+#    paths:
+#      - ".github/workflows/cli-release.yml"
+#      - ".goreleaser.yaml"
+#      - "go.mod"
+#      - "cli/**"


We can remove this now

begelundmuller · 2022-12-05T10:47:14Z

.goreleaser.yaml

+    flags:
+      - "-mod=readonly"
+    ldflags:
+      - -s -w -X main.Version={{.Version}} -X main.Commit={{.ShortCommit}} -X main.BuildDate={{.Date}}


I tested this, and noticed that running rill version outputs the correct version and commit hash, but for the build date, it outputs the current time, not the build time. Can you fix this? I think it might be because of the assignment in main.go, but not sure – maybe just have it be the zero time (var BuildDate time.Time) instead of time.Now()

Yeah it is because of assignment in main.go

.goreleaser.yaml

* goreleaser prototype setup * using goreleaser-cross to cross-compile for other platform * added formatting in yaml file * prettier * adding homebrew tap to cli * goreleaser homebrew setup fix * adding sysroot as submodule * adding sysroot as submodule * add submodule * added access token and created tap repo * build a snapshot * Update .goreleaser.yaml * update Makefile * add gcs support - remove makefile - formatting * snapshot wont upload * no release as of now * revert: fetch tags * gitignore error=git is in a dirty state * Skips git checks * disable scm release * typo * adding back the makefile for cli and proto * requested PR changes * Install npm * disable submodules on travis * make it pretty * node16 * version missing npm * goreleaser :facepalm: * curl * typo * testing without goreleaser-cross * commenting npm install step * commenting env vars in goreleaser.yaml * updating cobra cli version * update GH action * update go version * build both arm/amd * build linux too * nodejs * only macos * build linux too * testing with args to goreleaser.yaml * reverting changes * uncommenting linux build as in goreleaser * test goos in env vars * Reverting changes * testing with diff .goreleaser files * Update .goreleaser.yaml * cleanup * remove sysroot * another cleanup * Update .goreleaser.linux.yaml * upload for nightly * upload to gcs at particular path * Update .github/workflows/cli-release.yml * release via cross compile example * removed docker from makefile * adding secrets env * cleanup * fix tabs * Update .github/workflows/cli-release.yml * comment wrap_in_directory * checksum * typo * brew url template * fix yaml * Update .goreleaser.yaml * Update .goreleaser.yaml * fixing installation from homebrew * Update cli-release.yml * move make cli to workflow * Update cli-release.yml * tabs * new name * updated binary name and added makefile * fixed .goreleaser * added make cli * adding pre hooks * prettier fix * embed * dont remove dist * debug * Update .goreleaser.yaml * copy contents * try adding mime * go mod tidy * UI embed fix * go fmt ./.. * Apply suggestions from code review * Update .goreleaser.yaml * try snapshot for nightlies? * add arm64 * upload to latest too * upload all * goreleaser prototype setup * using goreleaser-cross to cross-compile for other platform * added formatting in yaml file * prettier * adding homebrew tap to cli * goreleaser homebrew setup fix * adding sysroot as submodule * add submodule * adding sysroot as submodule * added access token and created tap repo * build a snapshot * Update .goreleaser.yaml * update Makefile * add gcs support - remove makefile - formatting * snapshot wont upload * no release as of now * gitignore error=git is in a dirty state * Skips git checks * disable scm release * typo * adding back the makefile for cli and proto * requested PR changes * Install npm * disable submodules on travis * make it pretty * node16 * version missing npm * goreleaser :facepalm: * curl * typo * testing without goreleaser-cross * commenting npm install step * commenting env vars in goreleaser.yaml * updating cobra cli version * update GH action * build both arm/amd * build linux too * only macos * build linux too * testing with args to goreleaser.yaml * reverting changes * uncommenting linux build as in goreleaser * test goos in env vars * Reverting changes * testing with diff .goreleaser files * cleanup * remove sysroot * another cleanup * upload for nightly * Update .goreleaser.linux.yaml * upload to gcs at particular path * Update .github/workflows/cli-release.yml * release via cross compile example * removed docker from makefile * adding secrets env * cleanup * comment wrap_in_directory * checksum * typo * brew url template * fix yaml * Update .goreleaser.yaml * Update .goreleaser.yaml * fixing installation from homebrew * Update cli-release.yml * new name * updated binary name and added makefile * fixed .goreleaser * prettier fix * dont remove dist * debug * copy contents * try adding mime * go mod tidy * Apply suggestions from code review * Update .goreleaser.yaml * try snapshot for nightlies? * add arm64 * Update cli-release.yml * Update .goreleaser.yaml * go mod tidy * .goreleaser.yaml id name * updating GH action with make cli.prepare * typo * Update Makefile * Update .goreleaser.yaml * Update cli-release.yml * Update cli-release.yml * only on tags * ignore sysroot/ * requested changes * removed cron * Apply suggestions from code review Co-authored-by: Himadri Singh <[email protected]>

rakeshsharma14317 added 2 commits November 23, 2022 00:06

goreleaser prototype setup

b4a8b05

Merge remote-tracking branch 'origin/main' into goreleaser-prototype

c8d1f18

rakeshsharma14317 force-pushed the goreleaser-prototype branch from 412c995 to c8d1f18 Compare November 22, 2022 18:37

rakeshsharma14317 changed the title ~~goreleaser prototype setup~~ [Draft] goreleaser prototype setup Nov 22, 2022

rakeshsharma14317 requested a review from begelundmuller November 23, 2022 14:41

rakeshsharma14317 added 2 commits November 23, 2022 20:22

using goreleaser-cross to cross-compile for other platform

e92b2cd

Merge remote-tracking branch 'origin/main' into goreleaser-prototype

3966b9f

rakeshsharma14317 force-pushed the goreleaser-prototype branch from 855155c to 3966b9f Compare November 23, 2022 14:53

rakeshsharma14317 and others added 3 commits November 23, 2022 20:52

added formatting in yaml file

9375991

prettier

953b2eb

adding homebrew tap to cli

4bfb53c

rakeshsharma14317 force-pushed the goreleaser-prototype branch from 6092071 to 4bfb53c Compare November 24, 2022 11:10

Merge remote-tracking branch 'origin/main' into goreleaser-prototype

7ae4988

rakeshsharma14317 force-pushed the goreleaser-prototype branch 3 times, most recently from 6bceaec to e53cbd4 Compare November 24, 2022 13:01

goreleaser homebrew setup fix

bb166e3

rakeshsharma14317 force-pushed the goreleaser-prototype branch 2 times, most recently from 11c3667 to 487c712 Compare November 24, 2022 14:58

adding sysroot as submodule

12cbcb6

rakeshsharma14317 force-pushed the goreleaser-prototype branch 2 times, most recently from 12cbcb6 to 8e8b1b1 Compare November 24, 2022 15:13

adding sysroot as submodule

ab0b77a

rakeshsharma14317 force-pushed the goreleaser-prototype branch from 8e8b1b1 to ab0b77a Compare November 24, 2022 15:15

himadrisingh and others added 3 commits November 24, 2022 20:46

add submodule

9189693

Merge branch 'goreleaser-prototype' of github.com:rilldata/rill-devel…

deae7b7

…oper into goreleaser-prototype

added access token and created tap repo

9bdf109

rakeshsharma14317 force-pushed the goreleaser-prototype branch from 5c9cd00 to 9bdf109 Compare November 24, 2022 15:36

himadrisingh added 2 commits November 24, 2022 22:05

build a snapshot

ccf5a74

Update .goreleaser.yaml

c2309b7

rakeshsharma14317 and others added 5 commits December 2, 2022 17:32

go mod tidy

b0c2740

Apply suggestions from code review

f8aed76

Update .goreleaser.yaml

7d50438

try snapshot for nightlies?

6612ac8

add arm64

1389582

rakeshsharma14317 force-pushed the goreleaser-prototype branch from b244511 to 1389582 Compare December 2, 2022 12:05

himadrisingh and others added 14 commits December 2, 2022 17:39

Update cli-release.yml

72e02fb

Update .goreleaser.yaml

e5e1c9d

Merge branch 'goreleaser-prototype' of github.com:rilldata/rill-devel…

3a48356

…oper into goreleaser-prototype

go mod tidy

b9cf507

.goreleaser.yaml id name

5ef7d2b

updating GH action with make cli.prepare

d2e847b

typo

d676e2b

Update Makefile

3496239

Update .goreleaser.yaml

22c673c

Update cli-release.yml

17167fa

Update cli-release.yml

c4e0b7a

only on tags

fabc2c3

Merge remote-tracking branch 'origin' into goreleaser-prototype

99b5898

ignore sysroot/

d5664b7

begelundmuller requested changes Dec 5, 2022

View reviewed changes

rakeshsharma14317 added 2 commits December 5, 2022 17:43

requested changes

bac86cf

removed cron

07ac3f1

begelundmuller self-requested a review December 5, 2022 15:47

begelundmuller approved these changes Dec 5, 2022

View reviewed changes

himadrisingh approved these changes Dec 5, 2022

View reviewed changes

.goreleaser.yaml Outdated Show resolved Hide resolved

.goreleaser.yaml Outdated Show resolved Hide resolved

.goreleaser.yaml Outdated Show resolved Hide resolved

Apply suggestions from code review

f1a42c7

rakeshsharma14317 merged commit 65885f9 into main Dec 5, 2022

rakeshsharma14317 deleted the goreleaser-prototype branch December 5, 2022 19:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Goreleaser setup #1279

Goreleaser setup #1279

rakeshsharma14317 commented Nov 22, 2022 •

edited by himadrisingh

Loading

begelundmuller Dec 5, 2022

begelundmuller Dec 5, 2022

rakeshsharma14317 Dec 5, 2022

begelundmuller Dec 5, 2022

begelundmuller Dec 5, 2022

rakeshsharma14317 Dec 5, 2022

begelundmuller Dec 5, 2022

begelundmuller Dec 5, 2022

rakeshsharma14317 Dec 5, 2022 •

edited

Loading

rakeshsharma14317 Dec 5, 2022

rakeshsharma14317 Dec 5, 2022

begelundmuller Dec 5, 2022

begelundmuller Dec 5, 2022

rakeshsharma14317 Dec 5, 2022

Goreleaser setup #1279

Goreleaser setup #1279

Conversation

rakeshsharma14317 commented Nov 22, 2022 • edited by himadrisingh Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rakeshsharma14317 Dec 5, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rakeshsharma14317 commented Nov 22, 2022 •

edited by himadrisingh

Loading

rakeshsharma14317 Dec 5, 2022 •

edited

Loading