Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The visual weight of include/exclude icons are not heavy enough in the filter pills #1261

Closed
magorlick opened this issue Nov 18, 2022 · 0 comments · Fixed by #1512
Closed

The visual weight of include/exclude icons are not heavy enough in the filter pills #1261

magorlick opened this issue Nov 18, 2022 · 0 comments · Fixed by #1512

Comments

@magorlick
Copy link
Contributor

Issue
The visual weight of the check is not heavy enough in the filter pills. Might be the same icon as the leaderboards, but it doesn't read the same way in the filter pills.

Importance
It should be easy to scan and understand what is going on with a consistent mental model across include/exclude views.

Definition of Done
Increase the size of the icons in the filter pills. They shouldn't be as big as they are in the leaderboards, but they are too small as is.
@magorlick magorlick added the task label Nov 18, 2022
bcolloran added a commit that referenced this issue Nov 18, 2022
@bcolloran
use italics for deselected items in filter pill menu
c1b737f 
fixes #1261
@bcolloran bcolloran mentioned this issue Nov 18, 2022
Merged
@magorlick magorlick reopened this Nov 29, 2022
bcolloran added a commit that referenced this issue Dec 21, 2022
@bcolloran
fix The visual weight of include/exclude icons are not heavy enough i…
4dc5273 
…n the filter pills #1261
@bcolloran bcolloran mentioned this issue Dec 21, 2022
Merged
hamilton pushed a commit that referenced this issue Dec 22, 2022
@bcolloran
fix The visual weight of include/exclude icons are not heavy enough i…
19a7f11 
…n the filter pills #1261 (#1512)
djbarnwal pushed a commit that referenced this issue Aug 3, 2023
@bcolloran
lighten up leaderboards (#1236)
4cd9b09 
* lighten up leaderboards
- lighten bars
- lighten font weight
- remove refs to undefined styles `leaderboard-list-item-*`
- fix dimension table excluded text -> italic

* need to manually set "font-normal" in table cells

* update cell

* add bold text and darker bar for selections

* use italics for deselected items in filter pill menu
fixes #1261
djbarnwal pushed a commit that referenced this issue Aug 3, 2023
@bcolloran
fix The visual weight of include/exclude icons are not heavy enough i…
51d8c81 
…n the filter pills #1261 (#1512)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

increases visual weight of filter icons in filter pill menu rilldata/rill
1 participant
@magorlick