Highlighting of modules on current master is same color as values

[fhammerschmidt]

Yesterday I packaged the current master (at commit 287b4aa) into a VSIX and tested it.

Now it looks like this:

While the first iteration (not sure which commit, but it was the VSIX from the forum post) looked like this:

VSCode version: 1.65.2
Theme: Dark+

[zth]

Curious, did you build the analysis bin? This looks like semantic highlighting not running at all.

[fhammerschmidt]

That may be the case, I only bumped the version and copied the binaries from this action to server/analysis_binaries and did a vsce package.

(basically what is mentioned in https://github.com/rescript-lang/rescript-vscode/blob/master/CONTRIBUTING.md#release without the publish step).

[zth]

Yeah I see. That does look like it should work. But, you can test whether it's really broken or something just went wrong with packaging by building the analysis binary locally, and then running the extension in debug mode in VSCode. If things still don't work then, but hovers etc work, then something's broken for real.

[fhammerschmidt]

Fortunately, in Debug mode and built locally it works.

EDIT: I packaged them again with the current master (and now also unzipped them correctly) and now it works. Sorry, this was my bad.

[zth]

Thanks for the elaborate testing, happy it worked out in the end! I guess no bug is always better 😅