Skip to content

Breaking change from #3001 missing from changelog #3348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
airwoodix opened this issue Aug 6, 2024 · 2 comments
Open

Breaking change from #3001 missing from changelog #3348

airwoodix opened this issue Aug 6, 2024 · 2 comments

Comments

@airwoodix
Copy link

airwoodix commented Aug 6, 2024

Version: 5.0.8

Description: #3001 was marked as breaking change and released (for the 5.0-series) in 5.0.8 but is not mentioned in the changelog.

Would it be possible to add it there?

Example corresponding change:

import redis

x = redis.Redis()
print(repr(x))

displays

In 5.0.7:

Redis<ConnectionPool<Connection<host=localhost,port=6379,db=0>>>

In 5.0.8:

<redis.client.Redis(<redis.connection.ConnectionPool(<redis.connection.Connection(host=localhost,port=6379,db=0)>)>)>
@petyaslavova
Copy link
Collaborator

Hi @airwoodix, there is an open PR changing a similar change, and I didn't think it could be a breaking change...
Can you please provide a short description of the way you are relying on the string representation of the object - is it related to your application logic, or do you use it in your tests?

@airwoodix
Copy link
Author

Thanks @petyaslavova for the feedback!

We were using the repr in doctests, which failed after the update. This is not problem, we were just surprised not to find a mention of it in the changelog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants