Skip to content

Conversation

kalexand-rh
Copy link
Contributor

Fixes #175

@kalexand-rh kalexand-rh requested a review from a team as a code owner November 3, 2021 19:42
@sterobin
Copy link
Contributor

Updated #175 to summarize the proposal.

@@ -13,6 +13,14 @@ NOTE: A text snippet is not a module.
. Create the text snippet AsciiDoc file.
+
NOTE: Consider storing snippet files in a separate snippets folder.

. Add a variable to the snippet files that that identifies its content type:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kalexand-rh Typo "that that"

Copy link
Contributor

@sterobin sterobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kalexand-rh . Just a couple minor comments.

@@ -27,13 +27,14 @@ Create assembly and module file names that accurately and closely reflect the ti
Do not include special characters in file names. Ensure that all members of your team use the same file naming conventions.
====

These file naming guidelines are optional but highly recommended. However, if your team does not include the module prefixes in file names followed by either a hyphen (-) or an underscore (_), include one of the following variables in each concept, procedure, and reference module before the module ID:
These file naming guidelines are optional but highly recommended. However, if your team does not include the module prefixes in file names followed by either a hyphen (-) or an underscore (_), include one of the following variables in each assembly file and concept, procedure, and reference module before the module ID:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
These file naming guidelines are optional but highly recommended. However, if your team does not include the module prefixes in file names followed by either a hyphen (-) or an underscore (_), include one of the following variables in each assembly file and concept, procedure, and reference module before the module ID:
These file naming guidelines are optional but highly recommended. However, if your team does not include the prefixes in file names followed by either a hyphen (-) or an underscore (_), include one of the following variables in each file before the anchor ID:

:_content-type: ASSEMBLY
:_content-type: CONCEPT
:_content-type: PROCEDURE
:_content-type: REFERENCE
Copy link
Contributor

@sterobin sterobin Nov 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a side note that I think is outside of the scope of this PR. We might want to update the intro section to this chap to also mention snippets, and include a snippet file in the example file names previously in this section, and then add a content-type of SNIPPET to this list. But snippets are still fairly new territory, so not sure if we're to a point that we want to mention it beyond the snippets section later in this guide, which you've correctly updated. So I think good for now unless someone wants to expand this section to include snippets in a separate PR.

@sterobin sterobin added the Discussion for discussion topics that may later become enhancements label Dec 8, 2021
@sterobin
Copy link
Contributor

sterobin commented Dec 8, 2021

In mod doc review board meeting Dec 8, 2021, decided to freeze this PR until the dust settles with Jupiter post-Summit to ensure that the requirements don't again change, and also to see at that point if we can get a concrete answer on how the distinction of content and even module type has actual customer value beyond just a new tooling requirement. To be discussed post-Summit.

@emmurphy1 emmurphy1 merged commit b3cbfe1 into redhat-documentation:master Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion for discussion topics that may later become enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an assembly attribute option
3 participants