Skip to content

Improve rubocop rules and fix issues #1281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Jul 19, 2023
Merged

Improve rubocop rules and fix issues #1281

merged 23 commits into from
Jul 19, 2023

Conversation

ahangarha
Copy link
Collaborator

Summary

Despite having the Rubocop configuration in the project, it was outdated and also not used. This PR updates the configuration, fixes the issues, and adds a workflow to ensure all new PRs follow the lining policies.

Note: Four issues still remain. They can be ignored but I think it is better to fix them.

Pull Request checklist

  • Add/update test to cover these changes not needed
  • Update documentation not needed
  • Update CHANGELOG file not needed

@justin808
Copy link
Collaborator

This is a lot of lines changed. I'm not sure this is justified.

@Judahmeek
Copy link
Collaborator

@justin808 Why would you say that linting isn't justified?

@ahangarha
Copy link
Collaborator Author

Only changing ' to " updates almost the entire project.

Now, this project follows nearly the same linting rules in our other projects, making it easier to work with.

@ahangarha ahangarha marked this pull request as ready for review July 1, 2023 06:45
@ahangarha ahangarha changed the title Improve rubocop ruls and fix issues Improve rubocop rules and fix issues Jul 12, 2023
@Judahmeek Judahmeek merged commit 5c93087 into master Jul 19, 2023
@Judahmeek Judahmeek deleted the improve-linters branch July 19, 2023 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants