-
Notifications
You must be signed in to change notification settings - Fork 197
Comparing changes
Open a pull request
base repository: rails/solid_queue
base: v1.1.5
head repository: rails/solid_queue
compare: v1.2.0
- 19 commits
- 36 files changed
- 11 contributors
Commits on Jun 10, 2025
-
Support Active Job Continuations
[Active Job Continuations](rails/rails#55127) will be added in Rails 8.1. Queue adapters need to implement the `stopping?` method to support them. Implement the method and set it to true when a worker is stopping. Also add Rails versions so we can test against Rails main. To prevent an explosion of combinations, I've switched to only testing against minor versions of Ruby.
Configuration menu - View commit details
-
Copy full SHA for 9bd2a1b - Browse repository at this point
Copy the full SHA 9bd2a1bView commit details
Commits on Jun 13, 2025
-
Gracefully fail claimed executions even if the supervisor process was…
… pruned e.g. due to sleep/wake in a dev app
Configuration menu - View commit details
-
Copy full SHA for 9f12681 - Browse repository at this point
Copy the full SHA 9f12681View commit details
Commits on Jun 16, 2025
-
Configuration menu - View commit details
-
Copy full SHA for 0fb7144 - Browse repository at this point
Copy the full SHA 0fb7144View commit details
Commits on Jun 17, 2025
-
Write about performance considerations when using concurrency controls
And point to the recommended way to do throttling.
Configuration menu - View commit details
-
Copy full SHA for 9ae32cb - Browse repository at this point
Copy the full SHA 9ae32cbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6437617 - Browse repository at this point
Copy the full SHA 6437617View commit details
Commits on Jun 21, 2025
-
fix(568): moving stop_heartbeat after shutdown so that workers are no…
…t considered dead during a graceful shutdown
Configuration menu - View commit details
-
Copy full SHA for 098a004 - Browse repository at this point
Copy the full SHA 098a004View commit details
Commits on Jun 28, 2025
-
Configuration menu - View commit details
-
Copy full SHA for e04c1f9 - Browse repository at this point
Copy the full SHA e04c1f9View commit details
Commits on Jul 7, 2025
-
Configuration menu - View commit details
-
Copy full SHA for 37ae2ce - Browse repository at this point
Copy the full SHA 37ae2ceView commit details -
Add capability to discard duplicate jobs with concurrency configuration
Remove 'duplicate' verbiage and use concurrency limits instead, simplify control flow Fix race condition vulnerability by changing logic to enqueue Add assertions when bulk enqueuing jobs with concurrency controls Dispatch jobs in the order they were enqueued Set ActiveJob successfully_enqueued for both enqueued/blocked and discarded jobs Change concurrency 'at_limit' -> 'on_conflict' Update discard logic to trigger an ActiveRecord rollback when attempting dispatch to prevent discarded job creation Change default on_conflict concurrency option to old behaviour (blocking execution) Add concurrent on_conflict documentation to README Add test for discarding grouped concurrent jobs Fix tests which expect raising enqueue errors Add test to confirm scheduled jobs are also discarded
Configuration menu - View commit details
-
Copy full SHA for a2e2e43 - Browse repository at this point
Copy the full SHA a2e2e43View commit details -
Co-authored-by: Philippe Tring <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f0ea968 - Browse repository at this point
Copy the full SHA f0ea968View commit details -
Configuration menu - View commit details
-
Copy full SHA for d8e0bd1 - Browse repository at this point
Copy the full SHA d8e0bd1View commit details -
Tidy up after merging two branches implementing the same feature
Configuration menu - View commit details
-
Copy full SHA for bd2b655 - Browse repository at this point
Copy the full SHA bd2b655View commit details
Commits on Jul 9, 2025
-
fix: race condition with interruptibles (#566)
* fix: race condition with interruptibles * fix: make attr_reader private
Configuration menu - View commit details
-
Copy full SHA for 16fb285 - Browse repository at this point
Copy the full SHA 16fb285View commit details -
Configuration menu - View commit details
-
Copy full SHA for ddfe719 - Browse repository at this point
Copy the full SHA ddfe719View commit details
Commits on Jul 10, 2025
-
improve readme to be more explicit about the recommended UI dashboard…
… and that it will be needed to look at it via the UI
Configuration menu - View commit details
-
Copy full SHA for 3a4b24c - Browse repository at this point
Copy the full SHA 3a4b24cView commit details -
Change the approach, destroying the job when it can't be enqueued
Otherwise we'd get inconsistent behaviour with other adapters like Sidekiq, where only jobs that are actually enqueued get assigned a provider_job_id. Turns out, issuing a DELETE query for a record that got inserted within a transaction works perfectly, even with bulk INSERT, so let's just avoid creating those jobs altogether.
Configuration menu - View commit details
-
Copy full SHA for d23be3c - Browse repository at this point
Copy the full SHA d23be3cView commit details
Commits on Jul 11, 2025
-
Configuration menu - View commit details
-
Copy full SHA for d036fbf - Browse repository at this point
Copy the full SHA d036fbfView commit details -
Merge pull request #594 from rails/concurrency-on-conflict-discard
Add support for a `discard` option in concurrency controls
Configuration menu - View commit details
-
Copy full SHA for a912126 - Browse repository at this point
Copy the full SHA a912126View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5e0586f - Browse repository at this point
Copy the full SHA 5e0586fView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v1.1.5...v1.2.0