Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rails/solid_queue
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.1.4
Choose a base ref
...
head repository: rails/solid_queue
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.1.5
Choose a head ref
  • 5 commits
  • 10 files changed
  • 4 contributors

Commits on Mar 24, 2025

  1. Order by concurrency_key before distinct

    Microsoft SQL Server requires a deterministic order when using `limit` (aka you have to provide `ORDER BY`). By default, in the MSSQL adapter, we inject a `ORDER BY [primary_key]` clause to achieve so, if not any `order` has been specified in the query.
    
    This now leads to an issue in Solid Queue, where `concurrency_key` is selected and MSSQL complains that `id` is not in its `SELECT` clause.
    
    I first looked into fixing this in the SQL adapter, but then found a test in `activerecord` itself (`test_pluck_and_distinct`) that orders first before calling `distinct`. So I would suggest to align Solid Queue here and order by `concurrency_key` prior to calling `distinct`.
    
    I am aware that the existing code works with SQlite, MySQL and PostgreSQL as these do not require to pass an `ORDER BY` clause with `LIMIT`. I don't think this small addition will cause any troubles on the other DBMS systems.
    andyundso authored and rosa committed Mar 24, 2025
    Configuration menu
    Copy the full SHA
    b022dae View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9161da0 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2025

  1. Release concurrency locks when supervisor fails the jobs handled by w…

    …orkers (#547)
    
    * Add test
    
    * Unblock blocked job after failing claimed execution only in method called by supervisor
    nerisa authored Apr 18, 2025
    Configuration menu
    Copy the full SHA
    95dc9b4 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2025

  1. Go back to using the original, self-pipe based implementation of inte…

    …rruptible
    
    For all Rubies, and not just Ruby < 3.2.
    This is looking like the most likely culprit of a memory leak pointed
    out for multiple people on #330
    rosa committed Apr 20, 2025
    Configuration menu
    Copy the full SHA
    4c3efc9 View commit details
    Browse the repository at this point in the history
  2. Bump solid_queue to 1.1.5

    rosa committed Apr 20, 2025
    Configuration menu
    Copy the full SHA
    0ee21e4 View commit details
    Browse the repository at this point in the history
Loading