-
Notifications
You must be signed in to change notification settings - Fork 196
Comparing changes
Open a pull request
base repository: rails/solid_queue
base: v1.0.0
head repository: rails/solid_queue
compare: v1.0.2
- 17 commits
- 25 files changed
- 7 contributors
Commits on Oct 1, 2024
-
Remove redundant
run
methods inSolidQueue::Processes
This commit removes one of the redundant `run` methods in `SolidQueue::Processes` Here are the warning messages appeared at Rails Nightly CI: https://buildkite.com/rails/rails-nightly/builds/1091#019244bc-9d36-476d-8924-5e2bea4cb728/1173-1176 ``` /usr/local/lib/ruby/gems/3.4.0+0/gems/solid_queue-1.0.0/lib/solid_queue/processes/runnable.rb:52: warning: method redefined; discarding old run /usr/local/lib/ruby/gems/3.4.0+0/gems/solid_queue-1.0.0/lib/solid_queue/processes/runnable.rb:44: warning: previous definition of run was here ```
Configuration menu - View commit details
-
Copy full SHA for e7198f4 - Browse repository at this point
Copy the full SHA e7198f4View commit details
Commits on Oct 3, 2024
-
This commit addresses the following warnings appeared at Rails Nightly CI https://buildkite.com/rails/rails-nightly/builds/1095#019249e3-405c-4c52-ad8d-497f46a5c6a5/1244-1249 ```ruby /usr/local/lib/ruby/gems/3.4.0+0/gems/solid_queue-1.0.0/lib/solid_queue/supervisor/pidfile.rb:32: warning: assigned but unused variable - e /usr/local/lib/ruby/gems/3.4.0+0/gems/solid_queue-1.0.0/app/models/solid_queue/record.rb:7: warning: ambiguous `**` has been interpreted as an argument prefix ``` Co-authored-by: Koichi ITO <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 8b640fc - Browse repository at this point
Copy the full SHA 8b640fcView commit details
Commits on Oct 5, 2024
-
Merge pull request #368 from yahonda/address_warnings
Address Ruby warnings
Configuration menu - View commit details
-
Copy full SHA for a57660c - Browse repository at this point
Copy the full SHA a57660cView commit details
Commits on Oct 6, 2024
-
Merge pull request #367 from yahonda/remove_redundant_run_methods
Remove redundant `run` methods in `SolidQueue::Processes`
Configuration menu - View commit details
-
Copy full SHA for 51c75be - Browse repository at this point
Copy the full SHA 51c75beView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4c9a81b - Browse repository at this point
Copy the full SHA 4c9a81bView commit details
Commits on Nov 7, 2024
-
Return enqueued active job from
RecurringTask#enqueue
So we can redirect to it after enqueuing manually from Mission Control.
Configuration menu - View commit details
-
Copy full SHA for 71cc52d - Browse repository at this point
Copy the full SHA 71cc52dView commit details
Commits on Nov 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 60e4ba4 - Browse repository at this point
Copy the full SHA 60e4ba4View commit details
Commits on Nov 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 95fcc3d - Browse repository at this point
Copy the full SHA 95fcc3dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0e59c07 - Browse repository at this point
Copy the full SHA 0e59c07View commit details
Commits on Nov 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 29863c9 - Browse repository at this point
Copy the full SHA 29863c9View commit details
Commits on Nov 15, 2024
-
Merge pull request #373 from npezza93/errors
Report errors to the Rails error reporter
Configuration menu - View commit details
-
Copy full SHA for 42ce2ac - Browse repository at this point
Copy the full SHA 42ce2acView commit details -
Update Solid Queue setup in dummy app
Separate `queue` database and bin/jobs to start. Also, refresh setup script to support `docker compose` and set up the 3 DBs.
Configuration menu - View commit details
-
Copy full SHA for f9b1db7 - Browse repository at this point
Copy the full SHA f9b1db7View commit details -
Use separate DB in tests and remove separate connection option
Since we'll use separate DBs for test, there's no need to run all tests with a separate connection.
Configuration menu - View commit details
-
Copy full SHA for 5b80074 - Browse repository at this point
Copy the full SHA 5b80074View commit details -
Fix queue order when combining multiple prefixes or prefixes and names
We were altering the original order to be exact names and then prefixes in the order returned by the DB, which doesn't need to be the order specified for the worker. This change ensures the order is respected.
Configuration menu - View commit details
-
Copy full SHA for 8fe17d1 - Browse repository at this point
Copy the full SHA 8fe17d1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6276b4e - Browse repository at this point
Copy the full SHA 6276b4eView commit details
Commits on Nov 16, 2024
-
Merge pull request #410 from rails/fix-queue-selection
Fix queue order when combining multiple prefixes or prefixes and names
Configuration menu - View commit details
-
Copy full SHA for 24bad6f - Browse repository at this point
Copy the full SHA 24bad6fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 393e3b9 - Browse repository at this point
Copy the full SHA 393e3b9View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v1.0.0...v1.0.2