Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rails/solid_queue
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 5e0586f
Choose a base ref
...
head repository: rails/solid_queue
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 77ac84e
Choose a head ref
  • 16 commits
  • 19 files changed
  • 3 contributors

Commits on Jul 13, 2025

  1. Configuration menu
    Copy the full SHA
    7a7ae43 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2025

  1. Fix devcontainer config

    rafaelfranca committed Jul 18, 2025
    Configuration menu
    Copy the full SHA
    dcf050b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ef42226 View commit details
    Browse the repository at this point in the history
  3. Make sure docker-compose is available in the devcontainer

    This is required to run the tests.
    rafaelfranca committed Jul 18, 2025
    Configuration menu
    Copy the full SHA
    c179f28 View commit details
    Browse the repository at this point in the history
  4. Don't reset all 3 databases in setup

    Just reset the current database selected.
    rafaelfranca committed Jul 18, 2025
    Configuration menu
    Copy the full SHA
    b3fdee5 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d870557 View commit details
    Browse the repository at this point in the history
  6. Don't lock thor version to 1.3.x

    This is blocking me to upgrade Rails to use thor 1.4.0.
    
    None of the Rails dependencies have upper bounds on any gem
    to avoid this kind of issues.
    rafaelfranca authored and rosa committed Jul 18, 2025
    Configuration menu
    Copy the full SHA
    4378a21 View commit details
    Browse the repository at this point in the history
  7. Merge pull request #599 from rails/rm-add-devcontainer

    Fix the devcontainer configuration
    rafaelfranca authored Jul 18, 2025
    Configuration menu
    Copy the full SHA
    2a307e4 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2025

  1. Set successfully_enqueued in Job.enqueue

    Even though this will be overwritten by Active Job when called through
    `perform_later`.
    
    This is necessary for recurring tasks, where we run the `enqueue`
    callbacks manually and call `Job.enqueue`. We rely on `successfully_enqueued?`
    to know whether we need to record the recurring execution. We were setting
    that no matter what after calling `Job.enqueue` because we were relying on
    that to raise (which would be the case for Active Record errors).
    
    In the case of discarding it because of concurrency controls, the job is simply
    not persisted but no error is raised, which means we were trying to
    record a recurring execution without a persisted job, which would raise.
    
    Fixes #598
    rosa committed Jul 21, 2025
    Configuration menu
    Copy the full SHA
    be1a5bc View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2025

  1. Fix flaky test for process recovery

    Especially with SQLite, where the forked process claims the job before
    the main process.
    
    See #602
    rosa committed Jul 22, 2025
    Configuration menu
    Copy the full SHA
    f8b609d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f433a99 View commit details
    Browse the repository at this point in the history
  3. Make concurrency tests less flaky

    Don't try to enforce sequential order for jobs, given that the order is
    not even guaranteed by Solid Queue. Rename the test job to reflect that.
    Fix also another test where we waited for a job to finish but not for it
    to release the semaphore, so it happened most of the times but sometimes
    it didn't.
    rosa committed Jul 22, 2025
    Configuration menu
    Copy the full SHA
    74b12c8 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    896912c View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    0ba1b7e View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2025

  1. Configuration menu
    Copy the full SHA
    50b5f77 View commit details
    Browse the repository at this point in the history
  2. Bump solid_queue to 1.2.1

    rosa committed Jul 23, 2025
    Configuration menu
    Copy the full SHA
    77ac84e View commit details
    Browse the repository at this point in the history
Loading