-
Notifications
You must be signed in to change notification settings - Fork 197
Comparing changes
Open a pull request
base repository: rails/solid_queue
base: 5e0586f
head repository: rails/solid_queue
compare: 77ac84e
- 16 commits
- 19 files changed
- 3 contributors
Commits on Jul 13, 2025
-
Configuration menu - View commit details
-
Copy full SHA for 7a7ae43 - Browse repository at this point
Copy the full SHA 7a7ae43View commit details
Commits on Jul 18, 2025
-
Configuration menu - View commit details
-
Copy full SHA for dcf050b - Browse repository at this point
Copy the full SHA dcf050bView commit details -
Configuration menu - View commit details
-
Copy full SHA for ef42226 - Browse repository at this point
Copy the full SHA ef42226View commit details -
Make sure docker-compose is available in the devcontainer
This is required to run the tests.
Configuration menu - View commit details
-
Copy full SHA for c179f28 - Browse repository at this point
Copy the full SHA c179f28View commit details -
Don't reset all 3 databases in setup
Just reset the current database selected.
Configuration menu - View commit details
-
Copy full SHA for b3fdee5 - Browse repository at this point
Copy the full SHA b3fdee5View commit details -
Configuration menu - View commit details
-
Copy full SHA for d870557 - Browse repository at this point
Copy the full SHA d870557View commit details -
Don't lock thor version to 1.3.x
This is blocking me to upgrade Rails to use thor 1.4.0. None of the Rails dependencies have upper bounds on any gem to avoid this kind of issues.
Configuration menu - View commit details
-
Copy full SHA for 4378a21 - Browse repository at this point
Copy the full SHA 4378a21View commit details -
Merge pull request #599 from rails/rm-add-devcontainer
Fix the devcontainer configuration
Configuration menu - View commit details
-
Copy full SHA for 2a307e4 - Browse repository at this point
Copy the full SHA 2a307e4View commit details
Commits on Jul 21, 2025
-
Set
successfully_enqueued
inJob.enqueue
Even though this will be overwritten by Active Job when called through `perform_later`. This is necessary for recurring tasks, where we run the `enqueue` callbacks manually and call `Job.enqueue`. We rely on `successfully_enqueued?` to know whether we need to record the recurring execution. We were setting that no matter what after calling `Job.enqueue` because we were relying on that to raise (which would be the case for Active Record errors). In the case of discarding it because of concurrency controls, the job is simply not persisted but no error is raised, which means we were trying to record a recurring execution without a persisted job, which would raise. Fixes #598
Configuration menu - View commit details
-
Copy full SHA for be1a5bc - Browse repository at this point
Copy the full SHA be1a5bcView commit details
Commits on Jul 22, 2025
-
Fix flaky test for process recovery
Especially with SQLite, where the forked process claims the job before the main process. See #602
Configuration menu - View commit details
-
Copy full SHA for f8b609d - Browse repository at this point
Copy the full SHA f8b609dView commit details -
Configuration menu - View commit details
-
Copy full SHA for f433a99 - Browse repository at this point
Copy the full SHA f433a99View commit details -
Make concurrency tests less flaky
Don't try to enforce sequential order for jobs, given that the order is not even guaranteed by Solid Queue. Rename the test job to reflect that. Fix also another test where we waited for a job to finish but not for it to release the semaphore, so it happened most of the times but sometimes it didn't.
Configuration menu - View commit details
-
Copy full SHA for 74b12c8 - Browse repository at this point
Copy the full SHA 74b12c8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 896912c - Browse repository at this point
Copy the full SHA 896912cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0ba1b7e - Browse repository at this point
Copy the full SHA 0ba1b7eView commit details
Commits on Jul 23, 2025
-
Configuration menu - View commit details
-
Copy full SHA for 50b5f77 - Browse repository at this point
Copy the full SHA 50b5f77View commit details -
Configuration menu - View commit details
-
Copy full SHA for 77ac84e - Browse repository at this point
Copy the full SHA 77ac84eView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 5e0586f...77ac84e