Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rails/solid_queue
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 29b1847
Choose a base ref
...
head repository: rails/solid_queue
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 3d3f55d
Choose a head ref
  • 6 commits
  • 5 files changed
  • 5 contributors

Commits on Oct 1, 2024

  1. Remove redundant run methods in SolidQueue::Processes 

    This commit removes one of the redundant `run` methods in `SolidQueue::Processes`

Here are the warning messages appeared at Rails Nightly CI:
https://buildkite.com/rails/rails-nightly/builds/1091#019244bc-9d36-476d-8924-5e2bea4cb728/1173-1176
```
/usr/local/lib/ruby/gems/3.4.0+0/gems/solid_queue-1.0.0/lib/solid_queue/processes/runnable.rb:52: warning: method redefined; discarding old run
/usr/local/lib/ruby/gems/3.4.0+0/gems/solid_queue-1.0.0/lib/solid_queue/processes/runnable.rb:44: warning: previous definition of run was here
```
    @yahonda
    yahonda committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    e7198f4 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2024

  1. Address Ruby warnings 

    This commit addresses the following warnings appeared at Rails Nightly CI
https://buildkite.com/rails/rails-nightly/builds/1095#019249e3-405c-4c52-ad8d-497f46a5c6a5/1244-1249

```ruby
/usr/local/lib/ruby/gems/3.4.0+0/gems/solid_queue-1.0.0/lib/solid_queue/supervisor/pidfile.rb:32: warning: assigned but unused variable - e
/usr/local/lib/ruby/gems/3.4.0+0/gems/solid_queue-1.0.0/app/models/solid_queue/record.rb:7: warning: ambiguous `**` has been interpreted as an argument prefix
```

Co-authored-by: Koichi ITO <[email protected]>
    @yahonda @koic
    yahonda and koic committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    8b640fc View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2024

  1. Merge pull request #368 from yahonda/address_warnings 

    Address Ruby warnings
    @dhh
    dhh authored Oct 5, 2024
    Configuration menu
    Copy the full SHA
    a57660c View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2024

  1. Merge pull request #367 from yahonda/remove_redundant_run_methods 

    Remove redundant `run` methods in `SolidQueue::Processes`
    @byroot
    byroot authored Oct 6, 2024
    Configuration menu
    Copy the full SHA
    51c75be View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. Return enqueued active job from RecurringTask#enqueue 

    So we can redirect to it after enqueuing manually from Mission Control.
    @rosa
    rosa committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    71cc52d View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2024

  1. Bump solid_queue to 1.0.1

    @rosa
    rosa committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    3d3f55d View commit details
    Browse the repository at this point in the history
Loading