Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rails/solid_queue
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 29b1847
Choose a base ref
...
head repository: rails/solid_queue
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 393e3b9
Choose a head ref
  • 17 commits
  • 25 files changed
  • 7 contributors

Commits on Oct 1, 2024

  1. Remove redundant run methods in SolidQueue::Processes

    This commit removes one of the redundant `run` methods in `SolidQueue::Processes`
    
    Here are the warning messages appeared at Rails Nightly CI:
    https://buildkite.com/rails/rails-nightly/builds/1091#019244bc-9d36-476d-8924-5e2bea4cb728/1173-1176
    ```
    /usr/local/lib/ruby/gems/3.4.0+0/gems/solid_queue-1.0.0/lib/solid_queue/processes/runnable.rb:52: warning: method redefined; discarding old run
    /usr/local/lib/ruby/gems/3.4.0+0/gems/solid_queue-1.0.0/lib/solid_queue/processes/runnable.rb:44: warning: previous definition of run was here
    ```
    yahonda committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    e7198f4 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2024

  1. Address Ruby warnings

    This commit addresses the following warnings appeared at Rails Nightly CI
    https://buildkite.com/rails/rails-nightly/builds/1095#019249e3-405c-4c52-ad8d-497f46a5c6a5/1244-1249
    
    ```ruby
    /usr/local/lib/ruby/gems/3.4.0+0/gems/solid_queue-1.0.0/lib/solid_queue/supervisor/pidfile.rb:32: warning: assigned but unused variable - e
    /usr/local/lib/ruby/gems/3.4.0+0/gems/solid_queue-1.0.0/app/models/solid_queue/record.rb:7: warning: ambiguous `**` has been interpreted as an argument prefix
    ```
    
    Co-authored-by: Koichi ITO <[email protected]>
    yahonda and koic committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    8b640fc View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2024

  1. Merge pull request #368 from yahonda/address_warnings

    Address Ruby warnings
    dhh authored Oct 5, 2024
    Configuration menu
    Copy the full SHA
    a57660c View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2024

  1. Merge pull request #367 from yahonda/remove_redundant_run_methods

    Remove redundant `run` methods in `SolidQueue::Processes`
    byroot authored Oct 6, 2024
    Configuration menu
    Copy the full SHA
    51c75be View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4c9a81b View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. Return enqueued active job from RecurringTask#enqueue

    So we can redirect to it after enqueuing manually from Mission Control.
    rosa committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    71cc52d View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2024

  1. Bump solid_queue to 1.0.1

    rosa committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    60e4ba4 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2024

  1. Small typo

    berkos authored and rosa committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    95fcc3d View commit details
    Browse the repository at this point in the history
  2. Bump to latest Ruby version

    berkos authored and rosa committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    0e59c07 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2024

  1. simplify raising

    npezza93 committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    29863c9 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2024

  1. Merge pull request #373 from npezza93/errors

    Report errors to the Rails error reporter
    rosa authored Nov 15, 2024
    Configuration menu
    Copy the full SHA
    42ce2ac View commit details
    Browse the repository at this point in the history
  2. Update Solid Queue setup in dummy app

    Separate `queue` database and bin/jobs to start. Also, refresh setup
    script to support `docker compose` and set up the 3 DBs.
    rosa committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    f9b1db7 View commit details
    Browse the repository at this point in the history
  3. Use separate DB in tests and remove separate connection option

    Since we'll use separate DBs for test, there's no need to run all tests
    with a separate connection.
    rosa committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    5b80074 View commit details
    Browse the repository at this point in the history
  4. Fix queue order when combining multiple prefixes or prefixes and names

    We were altering the original order to be exact names and then prefixes
    in the order returned by the DB, which doesn't need to be the order
    specified for the worker. This change ensures the order is respected.
    rosa committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    8fe17d1 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    6276b4e View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2024

  1. Merge pull request #410 from rails/fix-queue-selection

    Fix queue order when combining multiple prefixes or prefixes and names
    rosa authored Nov 16, 2024
    Configuration menu
    Copy the full SHA
    24bad6f View commit details
    Browse the repository at this point in the history
  2. Bump solid_queue to 1.0.2

    rosa committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    393e3b9 View commit details
    Browse the repository at this point in the history
Loading