Skip to content

Improve package-inferred-system dependency extraction #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

daewok
Copy link
Contributor

@daewok daewok commented Sep 11, 2021

Prior to this commit effectively only the direct dependencies of the parent
system of a package-inferred-system were extracted. This commit fixes that by
continuing to extract dependencies of inferred child systems.

Previously depcheck would produce the following dependency list for the
40ants-doc system:

40ants-doc 40ants-doc/core 40ants-doc/glossary 40ants-doc/restart asdf

With this commit, the following is instead produced:

40ants-doc asdf named-readtables pythonic-string-reader

Prior to this commit effectively only the direct dependencies of the parent
system of a package-inferred-system were extracted. This commit fixes that by
continuing to extract dependencies of inferred child systems.

Previously depcheck would produce the following dependency list for the
40ants-doc system:

    40ants-doc 40ants-doc/core 40ants-doc/glossary 40ants-doc/restart asdf

With this commit, the following is instead produced:

    40ants-doc asdf named-readtables pythonic-string-reader
@daewok
Copy link
Contributor Author

daewok commented Sep 11, 2021

This improvement should result in both the client handling fewer asdf:missing-dependency conditions and make ql:bundle-systems easier to use with package inferred systems as dependencies.

@quicklisp quicklisp merged commit 124199d into quicklisp:master Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants