-
Notifications
You must be signed in to change notification settings - Fork 7k
Port Multi-weight support from prototype to main TorchVision #5618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
52 commits
Select commit
Hold shift + click to select a range
d44e44d
Moving basefiles outside of prototype and porting Alexnet, ConvNext, …
datumbox 78f90ce
Porting googlenet
datumbox 548d9ca
Porting inception
datumbox 46ff348
Porting mnasnet
datumbox 58be05b
Porting mobilenetv2
datumbox 99930d5
Porting mobilenetv3
datumbox 9b4a3ef
Porting regnet
datumbox 3788fb8
Porting resnet
datumbox 0eabb0c
Porting shufflenetv2
datumbox 8c45c1a
Porting squeezenet
datumbox b7916d3
Porting vgg
datumbox a7fabb3
Porting vit
datumbox 76f017c
Fix docstrings
datumbox eb5254d
Fixing imports
datumbox 56e0e01
Adding missing import
datumbox 2a42fd2
Merge branch 'main' into multiweight/full
datumbox 34f45d0
Fix mobilenet imports
datumbox 7cd616c
Fix tests
datumbox 5ce348d
Fix prototype tests
datumbox a8650a4
Exclude get_weight from models on test
datumbox 08c5f9b
Fix init files
datumbox bc6d94f
Porting googlenet
datumbox c106748
Porting inception
datumbox db33f53
porting mobilenetv2
datumbox f342797
porting mobilenetv3
datumbox 3db3e77
porting resnet
datumbox 829c5c1
porting shufflenetv2
datumbox 469eadd
Fix test and linter
datumbox 66d7642
Fixing docs.
datumbox a39e60e
Porting Detection models (#5617)
datumbox 5a96c9a
Porting Optical Flow, Segmentation, Video models (#5619)
datumbox 6d96ed5
Porting docs, examples, tutorials and galleries (#5620)
datumbox 31dd3b8
Merge branch 'main' into multiweight
datumbox c88b8dc
Resolve conflict
datumbox f121ca7
Porting model tests (#5622)
datumbox 189cbc8
Merge branch 'main' into multiweight
datumbox db0fd27
Update CI on Multiweight branch to use the new weight download approa…
datumbox e8fa42c
Merge branch 'main' into multiweight
datumbox 96b99dc
Merge branch 'main' into multiweight
datumbox 0a612cb
Porting reference scripts and updating presets (#5629)
datumbox f51d5f8
Setting `weights_backbone` to its fully BC value (#5653)
datumbox 8b9631b
Update docs.
datumbox fea9e39
Update preprocessing on reference scripts.
datumbox 59bdfbd
Change qat/ptq to their full values.
datumbox e85f494
Refactoring preprocessing
datumbox 0b0fc82
Fix video preset
datumbox 903a3d5
No initialization on VGG if pretrained
datumbox cbec5b1
Merge branch 'main' into multiweight
datumbox db9139a
Fix warning messages for backbone utils.
datumbox 545e431
Adding star to all preset constructors.
datumbox da10c9b
Merge branch 'main' into multiweight
datumbox ff3fd54
Fix mypy.
datumbox File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Replying to https://github.com/pytorch/vision/pull/5618/files#r829105451 here because GitHub hides the
.yml
file)Are these tests really that long to run? If they are, could we simply just skip them for all non-linux CI jobs (we could even pin a Python version if we want to make sure they only run once)? No strong opinion but perhaps there are simpler solutions than adding a new job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They don't take that long for now and yes we could skip them on all but 1 configuration. One potential benefit from doing it this way is we don't have to run the tests on FBcode where we would have to download the weights serially from manifold.
Let's review the model testing strategy as a whole later this half and redesign our testing strategy. We can catch work together on this if you have the bandwidth.