[ONNX] Add and fix custom cards for ONNX #3287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3287
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
svekars
approved these changes
Mar 7, 2025
svekars
reviewed
Mar 7, 2025
index.rst
Outdated
| :image: _static/img/thumbnails/cropped/Exporting-PyTorch-Models-to-ONNX-Graphs.png | ||
| :link: advanced/onnx_registry_tutorial.html | ||
| :link: beginner/onnx_registry_tutorial.html |
There was a problem hiding this comment.
this link is 404: https://pytorch.org/tutorials/beginner/onnx_registry_tutorial.html
Suggested change
| :link: beginner/onnx_registry_tutorial.html | |
| :link: beginner/onnx/onnx_registry_tutorial.html |
index.rst
Outdated
| :header: Exporting a model with control flow to ONNX | ||
| :card_description: Demonstrate how to handle control flow logic while exporting a PyTorch model to ONNX. | ||
| :image: _static/img/thumbnails/cropped/Exporting-PyTorch-Models-to-ONNX-Graphs.png | ||
| :link: beginner/export_control_flow_model_to_onnx_tutorial.html |
There was a problem hiding this comment.
Same as above
Suggested change
| :link: beginner/export_control_flow_model_to_onnx_tutorial.html | |
| :link: beginner/onnx/export_control_flow_model_to_onnx_tutorial.html |
|
Sorry for missing that! Should be fixed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow the suggestion from #3223 (comment)
Description
This PR adds the new custom card for ONNX new tutorial page, and fix the 404 Error on registry page.
Checklist
cc @svekars @sekyondaMeta @AlannaBurke