Rollback ddp tutorial fix #1641
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relax GPU count to support devices with 2 GPUs
Summary: See pytorch#1621 Test Plan: Reviewers: Subscribers: Tasks: Tags:
|
Hey Shen, Brian -- this is follow up of #1621 |
|
✔️ Deploy Preview for pytorch-tutorials-preview ready! 🔨 Explore the source changes: e0214e9 🔍 Inspect the deploy log: https://app.netlify.com/sites/pytorch-tutorials-preview/deploys/611a948597d93c0007dbc445 😎 Browse the preview: https://deploy-preview-1641--pytorch-tutorials-preview.netlify.app/intermediate/ddp_tutorial |
|
@bowangbj Do we still need to land this? If so, I'll do so after confirm. Thanks! |
|
Hey, I'm going to close this as I think we took care of it in another PR. If you want to change the file, can you do a new PR? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsume: #1621
Context: #1621 base branch was messed up due to use of ghstack tool.