Skip to content

Update CUDA version to 10.2 #1373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 26, 2021
Merged

Update CUDA version to 10.2 #1373

merged 3 commits into from
Feb 26, 2021

Conversation

ranman
Copy link
Contributor

@ranman ranman commented Feb 23, 2021

No description provided.

@netlify
Copy link

netlify bot commented Feb 23, 2021

Deploy preview for pytorch-tutorials-preview ready!

Built with commit b01eac6

https://deploy-preview-1373--pytorch-tutorials-preview.netlify.app

@ranman ranman force-pushed the cuda-updates branch 2 times, most recently from 16c57b3 to d2fe576 Compare February 23, 2021 23:10
@@ -122,7 +122,7 @@ pytorch_tutorial_build_defaults: &pytorch_tutorial_build_defaults
command: |
set -e

export pyTorchDockerImageTag=291
export pyTorchDockerImageTag=9de29bef4a5dc0dd1dd19428d83e5a66a44a1ed2-d5ed57569b35aaa56850259a988130c0625addf2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typically the base images that we utilize for CI are just a commit SHA from $(git rev-parse HEAD:.circleci/docker) so they shouldn't include a -${WORKFLOW_ID} which is what I'm seeing here.

Basically any tag with a hyphen is reaped after 2 weeks in our build system by the ECR garbage collection script.

Suggested change
export pyTorchDockerImageTag=9de29bef4a5dc0dd1dd19428d83e5a66a44a1ed2-d5ed57569b35aaa56850259a988130c0625addf2
export pyTorchDockerImageTag=9de29bef4a5dc0dd1dd19428d83e5a66a44a1ed2

@ranman ranman changed the title Update CUDA version to 10.1 Update CUDA version to 10.2 Feb 24, 2021
@brianjo
Copy link
Contributor

brianjo commented Feb 25, 2021

Looks like we're really close on this. I'm rerunning the two failed workers. I think these are probably transient errors. I'll look deeper if they fail again.

@brianjo brianjo requested a review from malfet February 25, 2021 17:27
@brianjo
Copy link
Contributor

brianjo commented Feb 25, 2021

@malfet Looks like a windows issue. Can you look at it.

@brianjo
Copy link
Contributor

brianjo commented Feb 26, 2021

Since this passes all but the two windows tests, I'm going to deploy this to allow us to start to test 1.8. Thanks!

@brianjo brianjo merged commit 8d0b5cc into pytorch:master Feb 26, 2021
gaoteng-git pushed a commit to gaoteng-git/tutorials that referenced this pull request Mar 2, 2021
* use more modern python for devcontainer

* update to cuda10.2 for circleci builds

Co-authored-by: Brian Johnson <[email protected]>
rodrigo-techera pushed a commit to Experience-Monks/tutorials that referenced this pull request Nov 29, 2021
* use more modern python for devcontainer

* update to cuda10.2 for circleci builds

Co-authored-by: Brian Johnson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants