Skip to content

[1.8 release] Switch to LM dataset in torchtext 0.9.0 release #1349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 4, 2021

Conversation

zhangguanheng66
Copy link
Contributor

In torchtext 0.9.0 release, we will include the raw text datasets as beta release. This PR is to switch the data to the raw dataset.

This PR should be tested against pytorch 1.8.0 rc and torchtext 0.9.0 rc.

@zhangguanheng66
Copy link
Contributor Author

zhangguanheng66 commented Feb 9, 2021

We expect the CI tests to fail until we switch to 1.8.0-rc. The tutorial works with the nightly release of torchtext, which will be cut for the rc package.
cc @brianjo @cpuhrsch

@netlify
Copy link

netlify bot commented Feb 9, 2021

Deploy preview for pytorch-tutorials-preview ready!

Built with commit 9bed147

https://deploy-preview-1349--pytorch-tutorials-preview.netlify.app

@zhangguanheng66 zhangguanheng66 changed the title [1.8 release] Switch to raw text dataset in torchtext 0.9.0 release [1.8 release] Switch to raw LM text dataset in torchtext 0.9.0 release Feb 9, 2021
@zhangguanheng66 zhangguanheng66 changed the title [1.8 release] Switch to raw LM text dataset in torchtext 0.9.0 release [1.8 release] Switch to LM dataset in torchtext 0.9.0 release Feb 9, 2021
Base automatically changed from master to main February 16, 2021 19:33
Base automatically changed from main to master February 16, 2021 19:37
Copy link
Contributor

@cpuhrsch cpuhrsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brianjo brianjo added the 1.8 PRs for upcoming release label Mar 2, 2021
@brianjo brianjo changed the base branch from master to 1.8-RC5-TEST March 4, 2021 14:32
@brianjo brianjo merged commit 68ca41d into pytorch:1.8-RC5-TEST Mar 4, 2021
brianjo added a commit that referenced this pull request Mar 4, 2021
* Update build.sh

* Update audio tutorial for release pytorch 1.8 / torchaudio 0.8 (#1379)

* [wip] replace audio tutorial

* Update

* Update

* Update

* fixup

* Update requirements.txt

* update

* Update

Co-authored-by: Brian Johnson <[email protected]>

* [1.8 release] Switch to the new datasets in torchtext 0.9.0 release - text classification tutorial (#1352)

* switch to the new dataset API

* checkpoint

* checkpoint

* checkpoint

* update docs

* checkpoint

* switch to legacy vocab

* update to follow the master API

* checkpoint

* checkpoint

* address reviewer's comments

Co-authored-by: Guanheng Zhang <[email protected]>
Co-authored-by: Brian Johnson <[email protected]>

* [1.8 release] Switch to LM dataset in torchtext 0.9.0 release (#1349)

* switch to raw text dataset in torchtext 0.9.0 release

* follow the new API in torchtext master

Co-authored-by: Guanheng Zhang <[email protected]>
Co-authored-by: Brian Johnson <[email protected]>

* [WIP][FX] CPU Performance Profiling with FX (#1319)

Co-authored-by: Brian Johnson <[email protected]>

* [FX] Added fuser tutorial (#1356)

* Added fuser tutorial

* updated index.rst

* fixed conclusion

* responded to some comments

* responded to comments

* respond

Co-authored-by: Brian Johnson <[email protected]>

* Update numeric_suite_tutorial.py

* Tutorial combining DDP with Pipeline Parallelism to Train Transformer models (#1347)

* Tutorial combining DDP with Pipeline Parallelism to Train Transformer models.

Summary: Tutorial which places a pipe on GPUs 0 and 1 and another Pipe
on GPUs 2 and 3. Both pipe replicas are replicated via DDP. One process
drives GPUs 0 and 1 and another drives GPUs 2 and 3.

* Polish out some of the docs.

* Add thumbnail and address some comments.

Co-authored-by: pritam <[email protected]>

* More updates to numeric_suite

* Even more updates

* Update numeric_suite_tutorial.py

Hopefully that's the last one

* Update numeric_suite_tutorial.py

Last one

* Update build.sh

Co-authored-by: moto <[email protected]>
Co-authored-by: Guanheng George Zhang <[email protected]>
Co-authored-by: Guanheng Zhang <[email protected]>
Co-authored-by: James Reed <[email protected]>
Co-authored-by: Horace He <[email protected]>
Co-authored-by: Pritam Damania <[email protected]>
Co-authored-by: pritam <[email protected]>
Co-authored-by: Nikita Shulga <[email protected]>
rodrigo-techera pushed a commit to Experience-Monks/tutorials that referenced this pull request Nov 29, 2021
* Update build.sh

* Update audio tutorial for release pytorch 1.8 / torchaudio 0.8 (pytorch#1379)

* [wip] replace audio tutorial

* Update

* Update

* Update

* fixup

* Update requirements.txt

* update

* Update

Co-authored-by: Brian Johnson <[email protected]>

* [1.8 release] Switch to the new datasets in torchtext 0.9.0 release - text classification tutorial (pytorch#1352)

* switch to the new dataset API

* checkpoint

* checkpoint

* checkpoint

* update docs

* checkpoint

* switch to legacy vocab

* update to follow the master API

* checkpoint

* checkpoint

* address reviewer's comments

Co-authored-by: Guanheng Zhang <[email protected]>
Co-authored-by: Brian Johnson <[email protected]>

* [1.8 release] Switch to LM dataset in torchtext 0.9.0 release (pytorch#1349)

* switch to raw text dataset in torchtext 0.9.0 release

* follow the new API in torchtext master

Co-authored-by: Guanheng Zhang <[email protected]>
Co-authored-by: Brian Johnson <[email protected]>

* [WIP][FX] CPU Performance Profiling with FX (pytorch#1319)

Co-authored-by: Brian Johnson <[email protected]>

* [FX] Added fuser tutorial (pytorch#1356)

* Added fuser tutorial

* updated index.rst

* fixed conclusion

* responded to some comments

* responded to comments

* respond

Co-authored-by: Brian Johnson <[email protected]>

* Update numeric_suite_tutorial.py

* Tutorial combining DDP with Pipeline Parallelism to Train Transformer models (pytorch#1347)

* Tutorial combining DDP with Pipeline Parallelism to Train Transformer models.

Summary: Tutorial which places a pipe on GPUs 0 and 1 and another Pipe
on GPUs 2 and 3. Both pipe replicas are replicated via DDP. One process
drives GPUs 0 and 1 and another drives GPUs 2 and 3.

* Polish out some of the docs.

* Add thumbnail and address some comments.

Co-authored-by: pritam <[email protected]>

* More updates to numeric_suite

* Even more updates

* Update numeric_suite_tutorial.py

Hopefully that's the last one

* Update numeric_suite_tutorial.py

Last one

* Update build.sh

Co-authored-by: moto <[email protected]>
Co-authored-by: Guanheng George Zhang <[email protected]>
Co-authored-by: Guanheng Zhang <[email protected]>
Co-authored-by: James Reed <[email protected]>
Co-authored-by: Horace He <[email protected]>
Co-authored-by: Pritam Damania <[email protected]>
Co-authored-by: pritam <[email protected]>
Co-authored-by: Nikita Shulga <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.8 PRs for upcoming release cla signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants