Remove lowering for index_select and add decomp for index_{add,add_} #1292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jansel
approved these changes
Sep 21, 2022
|
The error seems unrelated, but is it? |
I would suggest you to verify it locally. You can find the command used by CI at the top of the |
The decompositons and refs for these functions were added in core in pytorch/pytorch#85002. They generate the same code as the hand-written lowering.
|
The failures seem unrelated. |
fdrocha
pushed a commit
that referenced
this pull request
Sep 22, 2022
…1292) The decompositons and refs for these functions were added in core in pytorch/pytorch#85002. They generate the same code as the hand-written lowering.
fdrocha
pushed a commit
that referenced
this pull request
Oct 13, 2022
…1292) The decompositons and refs for these functions were added in core in pytorch/pytorch#85002. They generate the same code as the hand-written lowering. [ghstack-poisoned]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The decompositons and refs for these functions were added in core in pytorch/pytorch#85002. They generate the same code as the hand-written lowering.
Fixes #885