Skip to content

Deleted cuda graph files that were moved to torchdynamo #83128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Deleted cuda graph files that were moved to torchdynamo #83128

wants to merge 5 commits into from

Conversation

msaroufim
Copy link
Member

@msaroufim msaroufim commented Aug 9, 2022 •
edited
Loading

These files are now in pytorch/torchdynamo#757

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 9, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit e0ecef9 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@msaroufim msaroufim requested a review from ezyang August 9, 2022 23:30
@msaroufim msaroufim requested a review from anijain2305 August 9, 2022 23:36
@ezyang
Copy link
Contributor

ezyang commented Aug 10, 2022

This will be subsumed by pytorch/torchdynamo#757

@msaroufim
Copy link
Member Author

Sounds good, I'll repurpose this PR to delete what we no longer need in pytorch/pytorch

Tomorrow I'm spending some time looking at improving logging in the fx partitioner

@ezyang
Copy link
Contributor

ezyang commented Aug 10, 2022

Yes plz

@msaroufim msaroufim changed the title Fix broken dynamo cudagraph test Deleted cuda graph files that were moved to torchdynamo Aug 10, 2022
ezyang
ezyang approved these changes Aug 10, 2022
View reviewed changes
Copy link
Contributor

@ezyang ezyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@msaroufim
Copy link
Member Author

@pytorchbot merge -g

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link
Contributor

Hey @msaroufim.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Aug 11, 2022
@msaroufim @facebook-github-bot
Deleted cuda graph files that were moved to torchdynamo (#83128) (#83128
dc18754 
)

Summary:
These files are now in pytorch/torchdynamo#757

Pull Request resolved: #83128
Approved by: https://github.com/ezyang

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/0e8beb7d0d1c10e155d650dcf57a8468b3faa423

Reviewed By: seemethere

Differential Revision: D38600199

Pulled By: msaroufim

fbshipit-source-id: 04906e1907fc916a4b22158c277d5ca6cf49bfd7
@github-actions github-actions bot deleted the cudagraphdynamofixes branch February 19, 2024 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezyang ezyang ezyang approved these changes

@anijain2305 anijain2305 Awaiting requested review from anijain2305

Assignees
No one assigned
Labels
cla signed Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@msaroufim @facebook-github-bot @ezyang @pytorchmergebot