Add Per Tensor Quantization Support to FXIRImporter #55405
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💊 CI failures summary and remediationsAs of commit 01bd538 (more details on the Dr. CI page):
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
|
This pull request was exported from Phabricator. Differential Revision: D27313543 |
Codecov Report
@@ Coverage Diff @@
## master #55405 +/- ##
==========================================
- Coverage 77.43% 76.98% -0.46%
==========================================
Files 1892 1895 +3
Lines 187597 187719 +122
==========================================
- Hits 145268 144508 -760
- Misses 42329 43211 +882 |
Summary: Pull Request resolved: pytorch#55405 Pull Request resolved: pytorch/glow#5516 Allows FXIRImport to import quantized model. This diff doesn't include the supports for per-channel weights, linear and conv. Will address them in the next diff. Test Plan: buck test glow/fb/fx/nnpi_importer:test_importer Reviewed By: jackm321, jfix71 Differential Revision: D27313543 fbshipit-source-id: b730263a46537609aba8007330dc44b0b98d2d42
842974287
added a commit
to 842974287/glow
that referenced
this pull request
Apr 8, 2021
Summary: Pull Request resolved: pytorch/pytorch#55405 Pull Request resolved: pytorch#5516 Allows FXIRImport to import quantized model. This diff doesn't include the supports for per-channel weights, linear and conv. Will address them in the next diff. Reviewed By: jackm321, jfix71 Differential Revision: D27313543 fbshipit-source-id: 240776c689f9a3bb8c955ba1a735e5bc0c9873f5
|
This pull request was exported from Phabricator. Differential Revision: D27313543 |
05d837f to
01bd538
Compare
|
This pull request has been merged in 02f8276. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 9, 2021
Summary: Pull Request resolved: #55405 Pull Request resolved: pytorch/glow#5516 Allows FXIRImport to import quantized model. This diff doesn't include the supports for per-channel weights, linear and conv. Will address them in the next diff. Test Plan: buck test glow/fb/fx/nnpi_importer:test_importer Reviewed By: jackm321, jfix71 Differential Revision: D27313543 fbshipit-source-id: bf5c96ef5f2ff1835c09db981e0ceefaec56dd5b
krshrimali
pushed a commit
to krshrimali/pytorch
that referenced
this pull request
May 19, 2021
Summary: Pull Request resolved: pytorch#55405 Pull Request resolved: pytorch/glow#5516 Allows FXIRImport to import quantized model. This diff doesn't include the supports for per-channel weights, linear and conv. Will address them in the next diff. Test Plan: buck test glow/fb/fx/nnpi_importer:test_importer Reviewed By: jackm321, jfix71 Differential Revision: D27313543 fbshipit-source-id: bf5c96ef5f2ff1835c09db981e0ceefaec56dd5b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Allows FXIRImport to import quantized model.
This diff doesn't include the supports for per-channel weights, linear and conv. Will address them in the next diff.
Test Plan: buck test glow/fb/fx/nnpi_importer:test_importer
Reviewed By: jackm321
Differential Revision: D27313543