cmake: fix ONNX_NAMESPACE if USE_SYSTEM_ONNX #54973
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💊 CI failures summary and remediationsAs of commit 3e9aa56 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Codecov Report
@@ Coverage Diff @@
## master #54973 +/- ##
=======================================
Coverage 77.45% 77.45%
=======================================
Files 1892 1892
Lines 186387 186387
=======================================
+ Hits 144359 144363 +4
+ Misses 42028 42024 -4 |
walterddr
approved these changes
Mar 31, 2021
|
@walterddr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
malfet
approved these changes
Mar 31, 2021
|
@walterddr merged this pull request in aeedd5c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ONNX_NAMESPACEis empty by default ifUSE_SYSTEM_ONNX ON, while it should be equal toonnx.