-
Notifications
You must be signed in to change notification settings - Fork 24.9k
[quant][graphmode][fx] Separate handling Copy operator to a helper function #54644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nction Summary: Previously we special case copy operator in normal insert observer code, this PR tries to split the special case logic to a separate function and keep the rest of the code clean. Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Mar 25, 2021
Closed
💊 CI failures summary and remediationsAs of commit 6ee1560 (more details on the Dr. CI page):
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
…a helper function" Summary: Previously we special case copy operator in normal insert observer code, this PR tries to split the special case logic to a separate function and keep the rest of the code clean. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D27314678](https://our.internmc.facebook.com/intern/diff/D27314678) [ghstack-poisoned]
…a helper function" Summary: Previously we special case copy operator in normal insert observer code, this PR tries to split the special case logic to a separate function and keep the rest of the code clean. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D27314678](https://our.internmc.facebook.com/intern/diff/D27314678) [ghstack-poisoned]
…a helper function" Summary: Previously we special case copy operator in normal insert observer code, this PR tries to split the special case logic to a separate function and keep the rest of the code clean. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D27314678](https://our.internmc.facebook.com/intern/diff/D27314678) [ghstack-poisoned]
jerryzh168
added a commit
that referenced
this pull request
Mar 25, 2021
…nction Summary: Previously we special case copy operator in normal insert observer code, this PR tries to split the special case logic to a separate function and keep the rest of the code clean. Test Plan: Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: ccccaca Pull Request resolved: #54644
vkuzo
reviewed
Mar 25, 2021
…a helper function" Summary: Previously we special case copy operator in normal insert observer code, this PR tries to split the special case logic to a separate function and keep the rest of the code clean. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D27314678](https://our.internmc.facebook.com/intern/diff/D27314678) [ghstack-poisoned]
jerryzh168
added a commit
that referenced
this pull request
Mar 25, 2021
…nction Summary: Previously we special case copy operator in normal insert observer code, this PR tries to split the special case logic to a separate function and keep the rest of the code clean. Test Plan: Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 2bb5658 Pull Request resolved: #54644
vkuzo
approved these changes
Mar 25, 2021
…a helper function" Summary: Previously we special case copy operator in normal insert observer code, this PR tries to split the special case logic to a separate function and keep the rest of the code clean. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D27314678](https://our.internmc.facebook.com/intern/diff/D27314678) [ghstack-poisoned]
…a helper function" Summary: Previously we special case copy operator in normal insert observer code, this PR tries to split the special case logic to a separate function and keep the rest of the code clean. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D27314678](https://our.internmc.facebook.com/intern/diff/D27314678) [ghstack-poisoned]
…a helper function" Summary: Previously we special case copy operator in normal insert observer code, this PR tries to split the special case logic to a separate function and keep the rest of the code clean. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D27314678](https://our.internmc.facebook.com/intern/diff/D27314678) [ghstack-poisoned]
This was referenced Mar 27, 2021
…a helper function" Summary: Previously we special case copy operator in normal insert observer code, this PR tries to split the special case logic to a separate function and keep the rest of the code clean. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D27314678](https://our.internmc.facebook.com/intern/diff/D27314678) [ghstack-poisoned]
…a helper function" Summary: Previously we special case copy operator in normal insert observer code, this PR tries to split the special case logic to a separate function and keep the rest of the code clean. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D27314678](https://our.internmc.facebook.com/intern/diff/D27314678) [ghstack-poisoned]
…a helper function" Summary: Previously we special case copy operator in normal insert observer code, this PR tries to split the special case logic to a separate function and keep the rest of the code clean. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D27314678](https://our.internmc.facebook.com/intern/diff/D27314678) [ghstack-poisoned]
…a helper function" Summary: Previously we special case copy operator in normal insert observer code, this PR tries to split the special case logic to a separate function and keep the rest of the code clean. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D27314678](https://our.internmc.facebook.com/intern/diff/D27314678) [ghstack-poisoned]
…a helper function" Summary: Previously we special case copy operator in normal insert observer code, this PR tries to split the special case logic to a separate function and keep the rest of the code clean. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D27314678](https://our.internmc.facebook.com/intern/diff/D27314678) [ghstack-poisoned]
…a helper function" Summary: Previously we special case copy operator in normal insert observer code, this PR tries to split the special case logic to a separate function and keep the rest of the code clean. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D27314678](https://our.internmc.facebook.com/intern/diff/D27314678) [ghstack-poisoned]
…a helper function" Summary: Previously we special case copy operator in normal insert observer code, this PR tries to split the special case logic to a separate function and keep the rest of the code clean. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D27314678](https://our.internmc.facebook.com/intern/diff/D27314678) [ghstack-poisoned]
…a helper function" Summary: Previously we special case copy operator in normal insert observer code, this PR tries to split the special case logic to a separate function and keep the rest of the code clean. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D27314678](https://our.internmc.facebook.com/intern/diff/D27314678) [ghstack-poisoned]
…a helper function" Summary: Previously we special case copy operator in normal insert observer code, this PR tries to split the special case logic to a separate function and keep the rest of the code clean. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D27314678](https://our.internmc.facebook.com/intern/diff/D27314678) [ghstack-poisoned]
…a helper function" Summary: Previously we special case copy operator in normal insert observer code, this PR tries to split the special case logic to a separate function and keep the rest of the code clean. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D27314678](https://our.internmc.facebook.com/intern/diff/D27314678) [ghstack-poisoned]
…a helper function" Summary: Previously we special case copy operator in normal insert observer code, this PR tries to split the special case logic to a separate function and keep the rest of the code clean. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D27314678](https://our.internmc.facebook.com/intern/diff/D27314678) [ghstack-poisoned]
This pull request has been merged in c57541c. |
jerryzh168
added a commit
that referenced
this pull request
Apr 6, 2021
…nction (#54644) Summary: Previously we special case copy operator in normal insert observer code, this PR tries to split the special case logic to a separate function and keep the rest of the code clean. Test Plan: Imported from OSS Reviewed By: vkuzo [ghstack-poisoned]
jerryzh168
added a commit
that referenced
this pull request
Apr 6, 2021
…nction (#54644) Summary: Previously we special case copy operator in normal insert observer code, this PR tries to split the special case logic to a separate function and keep the rest of the code clean. Test Plan: Imported from OSS Reviewed By: vkuzo ghstack-source-id: 48f3ea0 Pull Request resolved: #55429
jerryzh168
added a commit
that referenced
this pull request
Apr 7, 2021
…opy operator to a helper function (#54644)" Summary: Previously we special case copy operator in normal insert observer code, this PR tries to split the special case logic to a separate function and keep the rest of the code clean. Test Plan: Imported from OSS Reviewed By: vkuzo Differential Revision: [D27609972](https://our.internmc.facebook.com/intern/diff/D27609972) [ghstack-poisoned]
jerryzh168
added a commit
that referenced
this pull request
Apr 7, 2021
…a helper function (#54644)" Summary: Previously we special case copy operator in normal insert observer code, this PR tries to split the special case logic to a separate function and keep the rest of the code clean. Test Plan: Imported from OSS Reviewed By: vkuzo Differential Revision: [D27609972](https://our.internmc.facebook.com/intern/diff/D27609972) [ghstack-poisoned]
jerryzh168
added a commit
that referenced
this pull request
Apr 7, 2021
…opy operator to a helper function (#54644)" Summary: Previously we special case copy operator in normal insert observer code, this PR tries to split the special case logic to a separate function and keep the rest of the code clean. Test Plan: Imported from OSS Reviewed By: vkuzo Differential Revision: [D27609972](https://our.internmc.facebook.com/intern/diff/D27609972) [ghstack-poisoned]
jerryzh168
added a commit
that referenced
this pull request
Apr 7, 2021
…a helper function (#54644)" Summary: Previously we special case copy operator in normal insert observer code, this PR tries to split the special case logic to a separate function and keep the rest of the code clean. Test Plan: Imported from OSS Reviewed By: vkuzo Differential Revision: [D27609972](https://our.internmc.facebook.com/intern/diff/D27609972) [ghstack-poisoned]
jerryzh168
added a commit
that referenced
this pull request
Apr 7, 2021
…opy operator to a helper function (#54644)" Summary: Previously we special case copy operator in normal insert observer code, this PR tries to split the special case logic to a separate function and keep the rest of the code clean. Test Plan: Imported from OSS Reviewed By: vkuzo Differential Revision: [D27609972](https://our.internmc.facebook.com/intern/diff/D27609972) [ghstack-poisoned]
jerryzh168
added a commit
that referenced
this pull request
Apr 7, 2021
…a helper function (#54644)" Summary: Previously we special case copy operator in normal insert observer code, this PR tries to split the special case logic to a separate function and keep the rest of the code clean. Test Plan: Imported from OSS Reviewed By: vkuzo Differential Revision: [D27609972](https://our.internmc.facebook.com/intern/diff/D27609972) [ghstack-poisoned]
jerryzh168
added a commit
that referenced
this pull request
Apr 8, 2021
…opy operator to a helper function (#54644)" Summary: Previously we special case copy operator in normal insert observer code, this PR tries to split the special case logic to a separate function and keep the rest of the code clean. Test Plan: Imported from OSS Reviewed By: vkuzo Differential Revision: [D27609972](https://our.internmc.facebook.com/intern/diff/D27609972) [ghstack-poisoned]
jerryzh168
added a commit
that referenced
this pull request
Apr 8, 2021
…a helper function (#54644)" Summary: Previously we special case copy operator in normal insert observer code, this PR tries to split the special case logic to a separate function and keep the rest of the code clean. Test Plan: Imported from OSS Reviewed By: vkuzo Differential Revision: [D27609972](https://our.internmc.facebook.com/intern/diff/D27609972) [ghstack-poisoned]
jerryzh168
added a commit
that referenced
this pull request
Apr 8, 2021
…opy operator to a helper function (#54644)" Summary: Previously we special case copy operator in normal insert observer code, this PR tries to split the special case logic to a separate function and keep the rest of the code clean. Test Plan: Imported from OSS Reviewed By: vkuzo Differential Revision: [D27609972](https://our.internmc.facebook.com/intern/diff/D27609972) [ghstack-poisoned]
jerryzh168
added a commit
that referenced
this pull request
Apr 8, 2021
…a helper function (#54644)" Summary: Previously we special case copy operator in normal insert observer code, this PR tries to split the special case logic to a separate function and keep the rest of the code clean. Test Plan: Imported from OSS Reviewed By: vkuzo Differential Revision: [D27609972](https://our.internmc.facebook.com/intern/diff/D27609972) [ghstack-poisoned]
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 9, 2021
…nction (#54644) (#55429) Summary: Pull Request resolved: #55429 Previously we special case copy operator in normal insert observer code, this PR tries to split the special case logic to a separate function and keep the rest of the code clean. Test Plan: Imported from OSS Imported from OSS Reviewed By: vkuzo Differential Revision: D27609972 fbshipit-source-id: 378f6aa70f18c0b477b62b6efe236648748aae7e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Previously we special case copy operator in normal insert observer code, this PR tries to split the
special case logic to a separate function and keep the rest of the code clean.
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D27314678