[TensorExpr] Add IRVerifier. #52901
Closed
[TensorExpr] Add IRVerifier. #52901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR implements IR Verifier and adds a call to it in `LoopNest` constructors. Checks that were in expr/stmt constructors before are now moved to the corresponding `::make` functions or to the verifier. They didn't really help from the constructors anyway since an exception thrown from there led to a segfault due to the fact our memory management works (object was not fully created but was registered in the kernel arena for destruction anyway). Fixes #52778. [ghstack-poisoned]
ZolotukhinM
pushed a commit
that referenced
this pull request
Feb 26, 2021
This PR implements IR Verifier and adds a call to it in `LoopNest` constructors. Checks that were in expr/stmt constructors before are now moved to the corresponding `::make` functions or to the verifier. They didn't really help from the constructors anyway since an exception thrown from there led to a segfault due to the fact our memory management works (object was not fully created but was registered in the kernel arena for destruction anyway). Fixes #52778. ghstack-source-id: fca2186 Pull Request resolved: #52901
💊 CI failures summary and remediationsAs of commit 85d3df6 (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
Codecov Report
@@ Coverage Diff @@
## gh/ZolotukhinM/409/base #52901 +/- ##
===========================================================
- Coverage 78.01% 78.01% -0.01%
===========================================================
Files 1848 1849 +1
Lines 179696 179778 +82
===========================================================
+ Hits 140198 140255 +57
- Misses 39498 39523 +25 |
navahgar
approved these changes
Feb 26, 2021
| throw unsupported_dtype(); | ||
| } | ||
| if (t->dtype() != f->dtype()) { | ||
| if (t.dtype() != f.dtype()) { | ||
| throw malformed_input("Bad dtype in IfThenElse"); | ||
| } |
There was a problem hiding this comment.
These have already been moved to the verifier, right? Why do we need them here as well?
There was a problem hiding this comment.
I kept them in ::make methods whenever it was possible, since there they don't cause segfaults and will allow to catch the issue earlier.
Yeah, absolutely agree. In future we might have different verifiers as well (e.g. one that would check that all buffers has
They might be useful, let me add some. |
This PR implements IR Verifier and adds a call to it in `LoopNest` constructors. Checks that were in expr/stmt constructors before are now moved to the corresponding `::make` functions or to the verifier. They didn't really help from the constructors anyway since an exception thrown from there led to a segfault due to the fact our memory management works (object was not fully created but was registered in the kernel arena for destruction anyway). Fixes #52778. Differential Revision: [D26682928](https://our.internmc.facebook.com/intern/diff/D26682928) [ghstack-poisoned]
ZolotukhinM
pushed a commit
that referenced
this pull request
Mar 1, 2021
This PR implements IR Verifier and adds a call to it in `LoopNest` constructors. Checks that were in expr/stmt constructors before are now moved to the corresponding `::make` functions or to the verifier. They didn't really help from the constructors anyway since an exception thrown from there led to a segfault due to the way our memory management works (object was not fully created but was registered in the kernel arena for destruction anyway). Fixes #52778. ghstack-source-id: 755b513 Pull Request resolved: #52901
This PR implements IR Verifier and adds a call to it in `LoopNest` constructors. Checks that were in expr/stmt constructors before are now moved to the corresponding `::make` functions or to the verifier. They didn't really help from the constructors anyway since an exception thrown from there led to a segfault due to the fact our memory management works (object was not fully created but was registered in the kernel arena for destruction anyway). Fixes #52778. Differential Revision: [D26682928](https://our.internmc.facebook.com/intern/diff/D26682928) [ghstack-poisoned]
ZolotukhinM
pushed a commit
that referenced
this pull request
Mar 1, 2021
This PR implements IR Verifier and adds a call to it in `LoopNest` constructors. Checks that were in expr/stmt constructors before are now moved to the corresponding `::make` functions or to the verifier. They didn't really help from the constructors anyway since an exception thrown from there led to a segfault due to the way our memory management works (object was not fully created but was registered in the kernel arena for destruction anyway). Fixes #52778. ghstack-source-id: 8c99301 Pull Request resolved: #52901
|
@ZolotukhinM merged this pull request in e22da0a. |
aocsa
pushed a commit
to Quansight/pytorch
that referenced
this pull request
Mar 15, 2021
Summary: Pull Request resolved: pytorch#52901 This PR implements IR Verifier and adds a call to it in `LoopNest` constructors. Checks that were in expr/stmt constructors before are now moved to the corresponding `::make` functions or to the verifier. They didn't really help from the constructors anyway since an exception thrown from there led to a segfault due to the fact our memory management works (object was not fully created but was registered in the kernel arena for destruction anyway). Fixes pytorch#52778. Test Plan: Imported from OSS Reviewed By: navahgar Differential Revision: D26682928 Pulled By: ZolotukhinM fbshipit-source-id: c56524015cdffb1ed8bce4394509961a4071dcfa
xsacha
pushed a commit
to xsacha/pytorch
that referenced
this pull request
Mar 31, 2021
Summary: Pull Request resolved: pytorch#52901 This PR implements IR Verifier and adds a call to it in `LoopNest` constructors. Checks that were in expr/stmt constructors before are now moved to the corresponding `::make` functions or to the verifier. They didn't really help from the constructors anyway since an exception thrown from there led to a segfault due to the fact our memory management works (object was not fully created but was registered in the kernel arena for destruction anyway). Fixes pytorch#52778. Test Plan: Imported from OSS Reviewed By: navahgar Differential Revision: D26682928 Pulled By: ZolotukhinM fbshipit-source-id: c56524015cdffb1ed8bce4394509961a4071dcfa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This PR implements IR Verifier and adds a call to it in
LoopNestconstructors. Checks that were in expr/stmt constructors before are now
moved to the corresponding
::makefunctions or to the verifier. Theydidn't really help from the constructors anyway since an exception
thrown from there led to a segfault due to the fact our memory
management works (object was not fully created but was registered in the
kernel arena for destruction anyway).
Fixes #52778.
Differential Revision: D26682928