-
Notifications
You must be signed in to change notification settings - Fork 24.9k
Reenable test_nn tests for Windows #52051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0d03427
to
843c708
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@janeyx99 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have to reenable embedding test somewhere?
💊 CI failures summary and remediationsAs of commit 9c7a739 (more details on the Dr. CI page):
🕵️ 14 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
Job | Step | Action |
---|---|---|
Build | 🔁 rerun | |
Build | 🔁 rerun | |
Build | 🔁 rerun |
This comment was automatically generated by Dr. CI (expand for details).
Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group.
Ah yes, sorry this was sitting on top of another PR. The changes would be here: 843c708 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@janeyx99 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
843c708
to
9c7a739
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@janeyx99 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
@@ -447,7 +447,7 @@ Tensor _embedding_bag_per_sample_weights_backward_cuda( | |||
AT_ASSERT(weight.dim() == 2); | |||
AT_ASSERT(weight.size(1) == embedding_features); | |||
|
|||
const int threads_per_block = 1024; | |||
const int threads_per_block = 512; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we plan do something like
#ifdef _MSC_VER
const int threads_per_block = 512;
#else
const int threads_per_block = 1024;
#endif
Summary: Fixes pytorch#52002 Pull Request resolved: pytorch#52051 Reviewed By: ngimel Differential Revision: D26409749 Pulled By: janeyx99 fbshipit-source-id: 5fa76d4fff8cf0fe2130c925fde9dffd0d1e7172
Fixes #52002