-
Notifications
You must be signed in to change notification settings - Fork 24.9k
Build pytorch_android using Gradle wrapper. #51067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
💊 CI failures summary and remediationsAs of commit 664af49 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Codecov Report
@@ Coverage Diff @@
## master #51067 +/- ##
==========================================
- Coverage 80.82% 80.82% -0.01%
==========================================
Files 1948 1948
Lines 213169 213169
==========================================
- Hits 172289 172287 -2
- Misses 40880 40882 +2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lint check fails on having +x permission for gradlew
Run (! find . ( -path ./third_party -o -path ./.git -o -path ./torch/bin -o -path ./build ) -prune -o -type f -executable -regextype posix-egrep -not -regex '.+(.(bash|sh|py|so)|git-pre-commit|git-clang-format)$' -print | grep . || (echo 'The above files have executable permission; please remove their executable permission by using chmod -x
'; false))
./android/gradlew
The above files have executable permission; please remove their executable permission by using chmod -x
Error: Process completed with exit code 1.
Need to check if without this it will run correctly
An error occurred if did not have execute permission.
Do you want to revert d4076d2 commit ? |
This reverts commit d4076d2eec40cca2708cf2876009abc08a8acde5.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@IvanKobzarev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@IvanKobzarev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
@IvanKobzarev merged this pull request in 8ab22a0. |
Summary: [Here](https://docs.gradle.org/current/userguide/gradle_wrapper.html), there is the following description. `The recommended way to execute any Gradle build is with the help of the Gradle Wrapper` I took a little time to prepare Gradle for `pytorch_android` build. (version etc.) I think using Gradle wrapper will make `pytorch_android` build more seamless. Gradle wrapper version: 4.10.3 https://github.com/pytorch/pytorch/blob/250c71121b8ac2ef1899a2414c939d4d45fc2be4/.circleci/scripts/build_android_gradle.sh#L13 Pull Request resolved: pytorch#51067 Reviewed By: izdeby Differential Revision: D26315718 Pulled By: IvanKobzarev fbshipit-source-id: f8077d7b28dc0b03ee48bcdac2f5e47d9c1f04d9
Here, there is the following description.
The recommended way to execute any Gradle build is with the help of the Gradle Wrapper
I took a little time to prepare Gradle for
pytorch_android
build. (version etc.)I think using Gradle wrapper will make
pytorch_android
build more seamless.Gradle wrapper version: 4.10.3
pytorch/.circleci/scripts/build_android_gradle.sh
Line 13 in 250c711