Header cleanup #48728
Closed
Header cleanup #48728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mostly removing unnecessary includes so that TensorIterator.h can be included from NativeFunctions.h without causing cycles. There some cases where I moved code around so that I didn't have to pull in other unnecessary stuff. Signed-off-by: Edward Z. Yang <[email protected]> [ghstack-poisoned]
This was referenced Dec 2, 2020
💊 CI failures summary and remediationsAs of commit fddd90c (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 18 times. |
Mostly removing unnecessary includes so that TensorIterator.h can be included from NativeFunctions.h without causing cycles. There some cases where I moved code around so that I didn't have to pull in other unnecessary stuff. Signed-off-by: Edward Z. Yang <[email protected]> [ghstack-poisoned]
Mostly removing unnecessary includes so that TensorIterator.h can be included from NativeFunctions.h without causing cycles. There some cases where I moved code around so that I didn't have to pull in other unnecessary stuff. Signed-off-by: Edward Z. Yang <[email protected]> [ghstack-poisoned]
Mostly removing unnecessary includes so that TensorIterator.h can be included from NativeFunctions.h without causing cycles. There some cases where I moved code around so that I didn't have to pull in other unnecessary stuff. Signed-off-by: Edward Z. Yang <[email protected]> [ghstack-poisoned]
Mostly removing unnecessary includes so that TensorIterator.h can be included from NativeFunctions.h without causing cycles. There some cases where I moved code around so that I didn't have to pull in other unnecessary stuff. Signed-off-by: Edward Z. Yang <[email protected]> [ghstack-poisoned]
Mostly removing unnecessary includes so that TensorIterator.h can be included from NativeFunctions.h without causing cycles. There some cases where I moved code around so that I didn't have to pull in other unnecessary stuff. Signed-off-by: Edward Z. Yang <[email protected]> Differential Revision: [D25278030](https://our.internmc.facebook.com/intern/diff/D25278030) [ghstack-poisoned]
bhosmer
approved these changes
Dec 2, 2020
Codecov Report
@@ Coverage Diff @@
## gh/ezyang/881/base #48728 +/- ##
===================================================
Coverage 80.83% 80.83%
===================================================
Files 1860 1861 +1
Lines 200678 200678
===================================================
+ Hits 162223 162225 +2
+ Misses 38455 38453 -2 |
ezyang
added a commit
to ezyang/pytorch
that referenced
this pull request
Dec 3, 2020
Mostly removing unnecessary includes so that TensorIterator.h can be included from NativeFunctions.h without causing cycles. There some cases where I moved code around so that I didn't have to pull in other unnecessary stuff. Signed-off-by: Edward Z. Yang <[email protected]> ghstack-source-id: e8dbc21 Pull Request resolved: pytorch#48728
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Mostly removing unnecessary includes so that TensorIterator.h can be
included from NativeFunctions.h without causing cycles. There some
cases where I moved code around so that I didn't have to pull in other
unnecessary stuff.
I also moved TensorIterator from ATen/native to ATen so that it is available
even on mobile (where native headers aren't installed)
Signed-off-by: Edward Z. Yang [email protected]
Differential Revision: D25278030