Adding few updates for ROCm #613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pruthvistony
commented
Mar 8, 2021
- Handling MacOS and Windows case
- Handling LibTorch case
- Handling MacOS and Windows case - Handling LibTorch case
|
Deploy preview for pytorch-dot-org-preview processing. Building with commit 39ba26d |
|
@seemethere @malfet @jeffdaily @sunway513 |
malfet
requested changes
Mar 9, 2021
There was a problem hiding this comment.
Thank you for the cleanups, but do not make platform specific changes for build-from-source instructions.
Also, for MacOS platform common pattern is to provide instructions for installing CPU packages and mention in comment that accelerated package is not available on the platform
assets/quick-start-module.js
Outdated
Comment on lines
248
to
252
| "stable,source,macos,rocm4.0,python": | ||
| "<b>NOTE:</b> ROCm is not available on MacOS", | ||
|
|
||
| "stable,source,windows,rocm4.0,python": | ||
| "<b>NOTE:</b> ROCm is not available on Windows", |
There was a problem hiding this comment.
All build from source requests should just redirect to github.
Suggested change
| "stable,source,macos,rocm4.0,python": | |
| "<b>NOTE:</b> ROCm is not available on MacOS", | |
| "stable,source,windows,rocm4.0,python": | |
| "<b>NOTE:</b> ROCm is not available on Windows", |
assets/quick-start-module.js
Outdated
| @@ -255,7 +261,7 @@ function commandMessage(key) { | |||
| "Download here (Pre-cxx11 ABI): <br/><a href='https://download.pytorch.org/libtorch/cu111/libtorch-shared-with-deps-1.8.0%2Bcu111.zip'>https://download.pytorch.org/libtorch/cu111/libtorch-shared-with-deps-1.8.0%2Bcu11.zip</a><br/><br> Download here (cxx11 ABI): <br/><a href='https://download.pytorch.org/libtorch/cu111/libtorch-cxx11-abi-shared-with-deps-1.8.0%2Bcu111.zip'>https://download.pytorch.org/libtorch/cu111/libtorch-cxx11-abi-shared-with-deps-1.8.0%2Bcu111.zip</a>", | |||
|
|
|||
| "stable,libtorch,linux,rocm4.0,cplusplus": | |||
| "LibTorch binaries are not available for ROCm, please build it from source", | |||
| "LibTorch binaries are not yet available for ROCm", | |||
There was a problem hiding this comment.
Please leave "build it from source" sentence, as this is the only way for developer to get "LibTorch binaries"
assets/quick-start-module.js
Outdated
| @@ -363,7 +369,7 @@ function commandMessage(key) { | |||
| "Download here (Pre-cxx11 ABI): <br/><a href='https://download.pytorch.org/libtorch/nightly/cu111/libtorch-shared-with-deps-latest.zip'>https://download.pytorch.org/libtorch/nightly/cu111/libtorch-shared-with-deps-latest.zip</a><br/><br> Download here (cxx11 ABI): <br/><a href='https://download.pytorch.org/libtorch/nightly/cu111/libtorch-cxx11-abi-shared-with-deps-latest.zip'>https://download.pytorch.org/libtorch/nightly/cu111/libtorch-cxx11-abi-shared-with-deps-latest.zip</a>", | |||
|
|
|||
| "preview,libtorch,linux,rocm4.0,cplusplus": | |||
| "<b>NOTE:</b> Conda packages are not currently available for ROCm, please use pip instead<br />", | |||
| "LibTorch binaries are not yet available for ROCm", | |||
There was a problem hiding this comment.
Suggested change
| "LibTorch binaries are not yet available for ROCm", | |
| "LibTorch binaries are not yet available for ROCm, please build them from source", |
assets/quick-start-module.js
Outdated
Comment on lines
327
to
333
| "pip install --pre torch torchvision torchaudio -f https://download.pytorch.org/whl/nightly/cpu/torch_nightly.html<br /># ROCm is not available on MacOS", | ||
| "<b>NOTE:</b> ROCm is not available on MacOS", |
There was a problem hiding this comment.
This change is not necessary, as it follows the common pattern for MacOS platform, where all instruction point to CPU only package and in the comment mention that compute platform is not available
assets/quick-start-module.js
Outdated
| @@ -375,7 +381,7 @@ function commandMessage(key) { | |||
| "MacOS binaries do not support CUDA. Download CPU libtorch here: <br/><a href='https://download.pytorch.org/libtorch/nightly/cpu/libtorch-macos-latest.zip'> https://download.pytorch.org/libtorch/nightly/cpu/libtorch-macos-latest.zip </a>", | |||
|
|
|||
| "preview,libtorch,macos,rocm4.0,cplusplus": | |||
| "ROCm is not available on MacOS. Download CPU libtorch here: <br/><a href='https://download.pytorch.org/libtorch/nightly/cpu/libtorch-macos-latest.zip'> https://download.pytorch.org/libtorch/nightly/cpu/libtorch-macos-latest.zip </a>", | |||
| "<b>NOTE:</b> ROCm is not available on MacOS", | |||
There was a problem hiding this comment.
Please don't change this message
malfet
approved these changes
Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.