Support torch>=2.6 in word_language_model example #1347
Merged
+34
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-examples-preview canceled.
|
dvrogozh
commented
May 16, 2025
| @@ -1 +1 @@ | |||
| torch<2.6 | |||
| torch>=2.6 | |||
There was a problem hiding this comment.
torch.serialization.safe_globals I've used in this PR appeared in torch 2.5. The torch.load default to load weights was changed to True in 2.6. Since we in any case plan to bump dependency to 2.6 by using torch.accelerate, I think we can update the requirement to 2.6 right away.
dvrogozh
commented
May 16, 2025
Update the example usage of `torch.load()` with required safe globals. Signed-off-by: Dmitry Rogozhkin <[email protected]>
msaroufim
approved these changes
May 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update example usage of
torch.load()with required safe globals.CC: @msaroufim, @framoncg, @jafraustro