Skip to content

fix zero_grad default parameter #1172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2023
Merged

fix zero_grad default parameter #1172

merged 1 commit into from
Jul 22, 2023

Conversation

Officium
Copy link
Contributor

In PyTorch 2.0, the default setting of "set_to_none" in "zero_grad" is True, which leads to TypeError when accumulating gradients in BatchUpdateParameterServer.

Ref:
torch.optim.SGD.zero_grad in PyTorch 2.0
torch.optim.SGD.zero_grad in PyTorch 1.13

@facebook-github-bot
Copy link
Contributor

Hi @Officium!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@netlify
Copy link

netlify bot commented Jul 11, 2023

Deploy Preview for pytorch-examples-preview canceled.

Name Link
🔨 Latest commit d5394bd
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-examples-preview/deploys/64ad6147f2407600086587a8

@msaroufim msaroufim merged commit 6fc19c7 into pytorch:main Jul 22, 2023
YinZhengxun pushed a commit to YinZhengxun/mt-exercise-02 that referenced this pull request Mar 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants