Skip to content

Fix typos in the Lib directory #28775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 6, 2021
Merged

Fix typos in the Lib directory #28775

merged 3 commits into from
Oct 6, 2021

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Oct 6, 2021 •
edited
Loading

Like #28744 but for the Lib directory.

[skip issue] Opening a related issue is pending python/psf-infra-meta#130

codespell --ignore-words-list=aline,alo,ans,asend,atleast,ba,bloc,browseable,cant,crasher,crashers,commen,datas,datea,doesnot,donn,ende,filetest,filetests,fiter,fo,hda,hel,hellow,henc,hist,infinit,inout,interruptable,invokations,ist,ket,lable,larg,leapyear,mye,nams,nd,ned,nin,notmutch,nwe,oder,oll,parm,raison,responsable,seh,simeple,squirl,spawnve,sur,tbe,te,teh,tey,thow,timere,tre,trough,tthe,ue,upto,wile,wont --skip=".decTest,.txt,*.types" Lib

terryjreedy
terryjreedy requested changes Oct 6, 2021
View reviewed changes
Copy link
Member

@terryjreedy terryjreedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked everything, not just idlelib, and all the changes look correct. I checked a few with the handy web search bar. One other check will be sufficient.

The requested change is to change 'gui' to 'GUI' in a line with another correction.

If whoever merges this does not backport to both 3.10 and 3.9, please let me know as I want at least the idlelib changes backported and will do so if necessary.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@cclauss @terryjreedy
gui —> GUI
41e183a 
Co-authored-by: Terry Jan Reedy <[email protected]>
@cclauss cclauss requested review from terryjreedy and removed request for a team October 6, 2021 21:16
ericvsmith
ericvsmith requested changes Oct 6, 2021
View reviewed changes
Copy link
Member

@ericvsmith ericvsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for the one small change I suggest, these all look good to me.

@cclauss cclauss requested a review from ericvsmith October 6, 2021 21:25
ericvsmith
ericvsmith approved these changes Oct 6, 2021
View reviewed changes
Copy link
Member

@ericvsmith ericvsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@gpshead gpshead self-assigned this Oct 6, 2021
@gpshead gpshead removed the request for review from 1st1 October 6, 2021 22:57
@gpshead gpshead added needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes skip issue skip news docs Documentation in the Doc dir labels Oct 6, 2021
@gpshead
Copy link
Member

gpshead commented Oct 6, 2021

There are ~5 of these PRs, see #28745 (comment) for details on how we're handling them. TL;DR - I'm taking the reviews. Backports to 3.9 and 3.10 are being done (manually) to reduce potential for merge conflicts of other bugfix backports.

@gpshead gpshead merged commit 745c9d9 into python:main Oct 6, 2021
@miss-islington
Copy link
Contributor

Thanks @cclauss for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @cclauss and @gpshead, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 745c9d9dfc1ad6fdfdf1d07420c6273ff67fa5be 3.10

@miss-islington
Copy link
Contributor

Sorry @cclauss and @gpshead, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 745c9d9dfc1ad6fdfdf1d07420c6273ff67fa5be 3.9

@cclauss cclauss deleted the codespell-Lib branch October 7, 2021 06:01
@cclauss cclauss mentioned this pull request Oct 7, 2021
Merged
cclauss added a commit to cclauss/cpython that referenced this pull request Oct 7, 2021
@cclauss @terryjreedy
[3.9] Fix typos in the Lib directory (pythonGH-28775)
628eb16 
Fix typos in the Lib directory as identified by codespell.

Co-authored-by: Terry Jan Reedy <[email protected]>
(cherry picked from commit 745c9d9)
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Oct 7, 2021
@bedevere-bot
Copy link

GH-28803 is a backport of this pull request to the 3.9 branch.

cclauss added a commit to cclauss/cpython that referenced this pull request Oct 7, 2021
@cclauss
[3.10] Fix typos in the Lib directory (pythonGH-28775)
e0168be 
Fix typos in the Lib directory as identified by codespell.

Co-authored-by: Terry Jan Reedy <[email protected]>.
(cherry picked from commit 745c9d9)

Co-authored-by: Christian Clauss <[email protected]>
@bedevere-bot
Copy link

GH-28804 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Oct 7, 2021
miss-islington pushed a commit that referenced this pull request Oct 7, 2021
@cclauss
[3.9] Fix typos in the Lib directory (GH-28775) (GH-28803)
4346b81 
Fix typos in the Lib directory as identified by codespell.

Co-authored-by: Terry Jan Reedy <[email protected]>
(cherry picked from commit 745c9d9)

Automerge-Triggered-By: GH:JulienPalard
terryjreedy pushed a commit that referenced this pull request Oct 7, 2021
@cclauss
[3.10] Fix typos in the Lib directory (GH-28775) (GH-28804)
cfca4a6 
Fix typos in the Lib directory as identified by codespell.

Co-authored-by: Terry Jan Reedy <[email protected]>.
(cherry picked from commit 745c9d9)

Co-authored-by: Christian Clauss <[email protected]>
cjerdonek
cjerdonek reviewed Oct 10, 2021
View reviewed changes
cjerdonek
cjerdonek reviewed Oct 10, 2021
View reviewed changes
jaraco pushed a commit to jaraco/cpython that referenced this pull request Feb 17, 2023
@cclauss @terryjreedy @jaraco
Fix typos in the Lib directory (pythonGH-28775)
329ae9d 
Fix typos in the Lib directory as identified by codespell.

Co-authored-by: Terry Jan Reedy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpshead gpshead gpshead approved these changes

@cjerdonek cjerdonek cjerdonek left review comments

@terryjreedy terryjreedy terryjreedy requested changes

@ericvsmith ericvsmith ericvsmith approved these changes

@pganssle pganssle Awaiting requested review from pganssle pganssle is a code owner

Assignees

@gpshead gpshead

Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@cclauss @bedevere-bot @gpshead @miss-islington @cjerdonek @ericvsmith @terryjreedy @the-knights-who-say-ni