Skip to content

gh-112936: Fix IDLE: no Shell menu item in single-process mode #126598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 2, 2025
Merged

gh-112936: Fix IDLE: no Shell menu item in single-process mode #126598

merged 4 commits into from
May 2, 2025

Conversation

Xiaokang2022
Copy link
Contributor

@Xiaokang2022 Xiaokang2022 commented Nov 8, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Nov 8, 2024
Closed
@Xiaokang2022 Xiaokang2022 changed the title gh-112936: fix IDLE: no Shell menu item in single-process mode gh-112936: Fix IDLE: no Shell menu item in single-process mode Nov 9, 2024
@picnixz picnixz added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Nov 9, 2024
@Xiaokang2022
Copy link
Contributor Author

@terryjreedy , PTAL, it's easy, thanks!

@tomasr8 tomasr8 removed the needs backport to 3.12 only security fixes label Apr 10, 2025
serhiy-storchaka
serhiy-storchaka reviewed May 2, 2025
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

But please add a comment for clarity. If later we will add, remove of move the menu items, it will help to find errors.

@serhiy-storchaka serhiy-storchaka merged commit 7e7e49b into python:main May 2, 2025
43 checks passed
@miss-islington-app
Copy link

Thanks @Xiaokang2022 for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 2, 2025
@Xiaokang2022 @miss-islington
pythongh-112936: Fix IDLE: no Shell menu item in single-process mode (p…
850ba41 
…ythonGH-126598)

(cherry picked from commit 7e7e49b)

Co-authored-by: Zhikang Yan <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented May 2, 2025

GH-133310 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 2, 2025
@Xiaokang2022 Xiaokang2022 deleted the fix-idle-menu branch May 2, 2025 17:04
serhiy-storchaka pushed a commit that referenced this pull request May 2, 2025
@miss-islington @Xiaokang2022
[3.13] gh-112936: Fix IDLE: no Shell menu item in single-process mode (…
e2ad2c8 
…GH-126598) (GH-133310)

(cherry picked from commit 7e7e49b)

Co-authored-by: Zhikang Yan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@terryjreedy terryjreedy Awaiting requested review from terryjreedy terryjreedy is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Xiaokang2022 @serhiy-storchaka @tomasr8 @picnixz