-
Notifications
You must be signed in to change notification settings - Fork 159
Comparing changes
Open a pull request
base repository: pytest-dev/pytest-asyncio
base: da50ce5
head repository: pytest-dev/pytest-asyncio
compare: f2fe98e
- 11 commits
- 11 files changed
- 2 contributors
Commits on Apr 21, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 29a4265 - Browse repository at this point
Copy the full SHA 29a4265View commit details
Commits on May 30, 2021
-
Adjusted Hypothesis integration test to use the same event loop initi…
…alization as in the plugin. The plugin code creates a new event loop from the current event loop policy, whereas the fixture in the Hypothesis test uses get_event_loop. In Python 3.10 the use of get_event_loop was deprecated and causes the Hypothesis tests to fail. Signed-off-by: Michael Seifert <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e3ec312 - Browse repository at this point
Copy the full SHA e3ec312View commit details -
refactor: Removed TestUnexistingLoop.remove_loop fixture, because it …
…has no effect. Under Python 3.10, the remove_loop fixture raises: "DeprecationWarning: There is no current event loop" This means that the remove_loop fixture effectively does nothing. The test case is still kept, because it seemingly aims to test that the "asyncio" marker works inside test classes when no "event_loop" fixture is explicitly specified. Signed-off-by: Michael Seifert <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b27abe8 - Browse repository at this point
Copy the full SHA b27abe8View commit details -
refactor: Grouped test cases together that are related to the use of …
…the asyncio marker in class-based tests. Rephrased test names and comments to make the test intention more clear. Signed-off-by: Michael Seifert <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 70989fd - Browse repository at this point
Copy the full SHA 70989fdView commit details -
refactor: Replaced tests asserting that the event loop is properly cl…
…osed. Under Python 3.10, the tests raise: "DeprecationWarning: There is no current event loop" This means that the asyncio.get_event_loop does not return any existing loop. It creates a new loop as a side effect instead. Therefore, test_1 and test_3 will always be successful. However, it would be wrong to simply delete the tests without a replacement. Although, we cannot retrieve the default loop with get_event_loop, we can still retrieve it from the event loop policy. The new tests do exactly that and assert that the loop is a different object than in the tests before. Signed-off-by: Michael Seifert <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2751982 - Browse repository at this point
Copy the full SHA 2751982View commit details -
refactor: test_async_fixtures_with_finalizer no longer trigger a Depr…
…ecationWarning on Python 3.10. The code was adjusted to use asyncio.get_event_loop_policy().get_event_loop() rather than the deprecated asyncio.get_event_loop(). Some additional comments were added to clarify the circumstances under which the test can fail. Signed-off-by: Michael Seifert <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1c283bd - Browse repository at this point
Copy the full SHA 1c283bdView commit details -
build: Include Python 3.10 in Tox test runs.
Signed-off-by: Michael Seifert <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for be3b327 - Browse repository at this point
Copy the full SHA be3b327View commit details -
ci: Include Python 3.10 in the CI test run.
Signed-off-by: Michael Seifert <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 42ff5d1 - Browse repository at this point
Copy the full SHA 42ff5d1View commit details -
feat: Add support for Python 3.10.
Adjusted changelog and setup.py accordingly. Signed-off-by: Michael Seifert <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6ec7647 - Browse repository at this point
Copy the full SHA 6ec7647View commit details
Commits on Oct 15, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 4e1df31 - Browse repository at this point
Copy the full SHA 4e1df31View commit details -
Configuration menu - View commit details
-
Copy full SHA for f2fe98e - Browse repository at this point
Copy the full SHA f2fe98eView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff da50ce5...f2fe98e