Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: pypa/gh-action-pypi-publish
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.11.0
Choose a base ref
...
head repository: pypa/gh-action-pypi-publish
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.12.0
Choose a head ref
  • 20 commits
  • 4 files changed
  • 4 contributors

Commits on Nov 4, 2024

  1. Build Docker image and push to GHCR

    Up to this point, the project has been set up as a Docker action
    referencing the Dockerfile. The downside to using the Dockerfile for the
    action is that the Docker image must be built every time the action is
    used.
    
    This commit will set up the project to build the Docker image and push
    it to GitHub Container Registry (GHCR). This change will speed up user
    workflows every time the action is used because the workflows will
    simply pull the Docker image from GHCR instead of building again.
    
    Changes:
    
    - Add required metadata to Dockerfile
    - Build container image with GitHub Actions
    - Push container image to GHCR
    
    Docker actions support pulling in pre-built Docker images. The downside
    is that there's no way to specify the correct Docker tag because the
    GitHub Actions `image` and `uses:` keys don't accept any context.
    For example, if a user's workflow has
    `uses: pypa/gh-action-pypi-publish@release/v1.8`, then the action should
    pull in a Docker image built from the `release/v1.8` branch, something
    like `ghcr.io/pypa/gh-action-pypi-publish:release-v1.8` (Docker tags
    can't have `/`). The workaround is to switch the top-level `action.yml`
    to a composite action that then calls the Docker action, substituting
    the correct image name and tag.
    br3ndonland committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    783267b View commit details
    Browse the repository at this point in the history
  2. Fix pre-commit errors

    br3ndonland committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    e453f8c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0d8d505 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    aed6c4b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    f1f014b View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    cf5ce17 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    5ded531 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    a869dd3 View commit details
    Browse the repository at this point in the history
  9. Dump action as JSON

    br3ndonland committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    a360fcb View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    f51682f View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    7ea8313 View commit details
    Browse the repository at this point in the history
  12. Fail-fast in unsupported environments

    #230 (comment)
    
    Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
    br3ndonland and webknjaz committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    bacb626 View commit details
    Browse the repository at this point in the history
  13. Drop args from create-docker-action.py

    Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
    br3ndonland and webknjaz committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    d03addb View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    153ccde View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    cfb9d93 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    1b9f21a View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    80b1d50 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    da55441 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    36965cb View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2024

  1. Merge pull request #230 from br3ndonland/ghcr

    Build Docker image and push to GHCR
    webknjaz authored Nov 5, 2024
    Configuration menu
    Copy the full SHA
    61da13d View commit details
    Browse the repository at this point in the history
Loading