Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: postgresql-cfbot/postgresql
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: cf/5944~1
Choose a base ref
...
head repository: postgresql-cfbot/postgresql
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: cf/5944
Choose a head ref
  • 2 commits
  • 8 files changed
  • 2 contributors

Commits on Aug 11, 2025

  1. Mark GiST network_ops opcdefault, and btree_gist's opclasses not. 

    We want to deprecate btree_gist's gist_inet_ops and gist_cidr_ops
opclasses, because they sometimes give the wrong answers.  (We won't
remove those opclasses completely just yet, and even if we did,
it wouldn't make this undertaking any less messy.)  As a first
step on that road, make the replacement opclass the default one.

GetDefaultOpClass() enforces that there can be only one default
opclass per index AM and input datatype, so we have to remove
the DEFAULT markings on gist_inet_ops and gist_cidr_ops.  The
only way to do this that doesn't cause failures in pg_upgrade
is to hack up DefineOpClass() to ignore those markings.  Even
then, pg_upgrade would do the wrong things with such indexes,
so refuse to upgrade them.

TODO: user-facing docs, cross-version-upgrade test support.

XXX: don't forget catversion bump.
    @tglsfdc
    tglsfdc authored and Commitfest Bot committed Aug 11, 2025
    Configuration menu
    Copy the full SHA
    e61f8a8 View commit details
    Browse the repository at this point in the history

  2. [CF 5944] v1 - Fixing the btree_gist inet mess 

    This branch was automatically generated by a robot using patches from an
email thread registered at:

https://commitfest.postgresql.org/patch/5944

The branch will be overwritten each time a new patch version is posted to
the thread, and also periodically to check for bitrot caused by changes
on the master branch.

Patch(es): https://www.postgresql.org/message-id/[email protected]
Author(s): Tom Lane
    Commitfest Bot committed Aug 11, 2025
    Configuration menu
    Copy the full SHA
    62497a6 View commit details
    Browse the repository at this point in the history
Loading