Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: postgresql-cfbot/postgresql
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: cf/5894~1
Choose a base ref
...
head repository: postgresql-cfbot/postgresql
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: cf/5894
Choose a head ref
  • 2 commits
  • 4 files changed
  • 2 contributors

Commits on Aug 9, 2025

  1. Don't keep closed WAL segments in page cache after replay 

    The recovery process reads the WAL segments, applies changes and closes the
segment. When closed, the segments will still be in page cache memory until
they are evicted due to inactivity. The segments may be re-read if
archive_mode is set to always, wal_summarizer is enabled or if the stanby
is used for replication and has an active walsender.

Outside of those circumstances, the WAL segments won't be re-read and
keeping them in the page cache generates unnecessary memory pressure.

If the standby doesn't archive wal, doesn't have wal_summarize and
doesn't have an active walsender, a POSIX_FADV_DONTNEED is sent before
closing a replayed WAL segment to immediately free any cached pages.
    @bonnefoa
    bonnefoa authored and Commitfest Bot committed Aug 9, 2025
    Configuration menu
    Copy the full SHA
    8eb7617 View commit details
    Browse the repository at this point in the history

  2. [CF 5894] v02 - Don't keep closed WAL segment in page cache after replay 

    This branch was automatically generated by a robot using patches from an
email thread registered at:

https://commitfest.postgresql.org/patch/5894

The branch will be overwritten each time a new patch version is posted to
the thread, and also periodically to check for bitrot caused by changes
on the master branch.

Patch(es): https://www.postgresql.org/message-id/CAO6_Xqpx1ey8DPRub7fq4_-rtL=gygoSDHv4iLw5S3gG7=k1dw@mail.gmail.com
Author(s): Anthonin Bonnefoy
    Commitfest Bot committed Aug 9, 2025
    Configuration menu
    Copy the full SHA
    2681de4 View commit details
    Browse the repository at this point in the history
Loading