Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: postgresql-cfbot/postgresql
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: cf/5891~1
Choose a base ref
...
head repository: postgresql-cfbot/postgresql
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: cf/5891
Choose a head ref
  • 4 commits
  • 2 files changed
  • 2 contributors

Commits on Aug 10, 2025

  1. not restore comments if the associated object is excluded 

    If certain objects are excluded from restoration in pg_restore, then comments
associated with those objects should also not be restored.
So this patch applies to the following pg_restore option:
--no-policies, --no-publications, --no-subscriptions
TODO: need perl tests

discussion: https://postgr.es/m/[email protected]
    @jianhe-fun
    jianhe-fun authored and Commitfest Bot committed Aug 10, 2025
    Configuration menu
    Copy the full SHA
    08f157f View commit details
    Browse the repository at this point in the history

  2. make pg_dump dump security label for shared database objects 

    As noted in [1], SUBSCRIPTION and similar objects are treated as global objects.
Therefore, we should use pg_catalog.pg_seclabels in collectSecLabels instead of
pg_catalog.pg_seclabel.
The database’s own security label is handled via dumpDatabase, so this change
should be appropriate.

[1] https://www.postgresql.org/docs/devel/catalog-pg-shseclabel.html
discussion: https://postgr.es/m/CACJufxHCt00pR9h51AVu6+yPD5J7JQn=7dQXxqacj0XyDhc-fA@mail.gmail.com
commitfest entry: https://commitfest.postgresql.org/
    @jianhe-fun
    jianhe-fun authored and Commitfest Bot committed Aug 10, 2025
    Configuration menu
    Copy the full SHA
    5736869 View commit details
    Browse the repository at this point in the history

  3. not restore security labels if the associated object is excluded 

    When --no-publications or --no-subscriptions is specified in pg_restore,
security labels associated with those objects should be excluded.

pg_dump.c, dumpSecLabel function and the Security Label synopsis section [1] helps
verify that the TocEntry->tag string for a security label begins with the object
type it is associated with. So this patch change should be fine.

[1] https://www.postgresql.org/docs/current/sql-security-label.html
discussion: https://postgr.es/m/CACJufxHCt00pR9h51AVu6+yPD5J7JQn=7dQXxqacj0XyDhc-fA@mail.gmail.com
commitfest entry: https://commitfest.postgresql.org/
    @jianhe-fun
    jianhe-fun authored and Commitfest Bot committed Aug 10, 2025
    Configuration menu
    Copy the full SHA
    f048d1d View commit details
    Browse the repository at this point in the history

  4. [CF 5891] v2 - pg_restore --no-policies should not restore policies' … 

    …comment

This branch was automatically generated by a robot using patches from an
email thread registered at:

https://commitfest.postgresql.org/patch/5891

The branch will be overwritten each time a new patch version is posted to
the thread, and also periodically to check for bitrot caused by changes
on the master branch.

Patch(es): https://www.postgresql.org/message-id/CACJufxEc5CcU3Gw43q_ycX9wArEci5UYuv4hag9mPWWYueo5nA@mail.gmail.com
Author(s): Jian He
    Commitfest Bot committed Aug 10, 2025
    Configuration menu
    Copy the full SHA
    4c154e2 View commit details
    Browse the repository at this point in the history
Loading