Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: postgresql-cfbot/postgresql
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: cf/5832~1
Choose a base ref
...
head repository: postgresql-cfbot/postgresql
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: cf/5832
Choose a head ref
  • 2 commits
  • 25 files changed
  • 2 contributors

Commits on Aug 10, 2025

  1. Change the names generated for index partitions. 

    Instead of applying the default index-naming algorithm using the name
of the child partition, use the name of the parent partitioned index,
plus an underscore and some digit(s) as needed to make the name
unique.  This is similar to the rule adopted in commit 3db61db for
child foreign-key constraints.  As in that case, the immediate
motivation is to reduce the risk of index name collisions; but it
seems like this rule might be preferable from a user-experience
standpoint anyway.

Although these cases share code with CREATE TABLE LIKE ... INCLUDING
INDEXES, I kept the old behavior for CREATE TABLE LIKE.  It seems less
obvious that changing that would be a user-experience improvement,
since with CREATE TABLE LIKE there isn't any permanent connection of
the parent and child tables.  There is also a much larger
race-condition window for name collisions if we try to do this in
CREATE TABLE LIKE, since more time and indeed perhaps some other index
creations could occur before the actual index creation happens.
Finally, this is already a pretty big user-visible behavioral change;
not changing the much-longer-standing CREATE TABLE LIKE behavior
should reduce the blast radius a little bit.

Bug: #18959
Reported-by: Maximilian Chrzan <[email protected]>
Author: Tom Lane <[email protected]>
Discussion: https://postgr.es/m/[email protected]
    @tglsfdc
    tglsfdc authored and Commitfest Bot committed Aug 10, 2025
    Configuration menu
    Copy the full SHA
    e279e25 View commit details
    Browse the repository at this point in the history

  2. [CF 5832] v1 - Change the names generated for index partitions 

    This branch was automatically generated by a robot using patches from an
email thread registered at:

https://commitfest.postgresql.org/patch/5832

The branch will be overwritten each time a new patch version is posted to
the thread, and also periodically to check for bitrot caused by changes
on the master branch.

Patch(es): https://www.postgresql.org/message-id/[email protected]
Author(s): Tom Lane
    Commitfest Bot committed Aug 10, 2025
    Configuration menu
    Copy the full SHA
    fe0b678 View commit details
    Browse the repository at this point in the history
Loading